Skip to content

Commit 5f32b8f

Browse files
YLChenZYLChenZ
committed
add multi-use test
1 parent 74b7a41 commit 5f32b8f

File tree

1 file changed

+77
-44
lines changed

1 file changed

+77
-44
lines changed

‎llvm/test/Transforms/InstCombine/or-select-zero-icmp.ll‎

Lines changed: 77 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
12
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
23

34
; Basic functional test
45
define i32 @basic(i32 %a, i32 %b) {
5-
; CHECK-LABEL: @basic(
6-
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 0
7-
; CHECK-NEXT: [[RES:%.*]] = select i1 [[CMP]], i32 [[B:%.*]], i32 [[A]]
6+
; CHECK-LABEL: define i32 @basic(
7+
; CHECK-SAME: i32 [[A:%.*]], i32 [[B:%.*]]) {
8+
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A]], 0
9+
; CHECK-NEXT: [[RES:%.*]] = select i1 [[CMP]], i32 [[B]], i32 [[A]]
810
; CHECK-NEXT: ret i32 [[RES]]
911
;
1012
%cmp = icmp eq i32 %a, 0
@@ -15,9 +17,10 @@ define i32 @basic(i32 %a, i32 %b) {
1517

1618
; Operand order swap test
1719
define i32 @swap_operand_order(i32 %x, i32 %y) {
18-
; CHECK-LABEL: @swap_operand_order(
19-
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[X:%.*]], 0
20-
; CHECK-NEXT: [[RES:%.*]] = select i1 [[CMP]], i32 [[Y:%.*]], i32 [[X]]
20+
; CHECK-LABEL: define i32 @swap_operand_order(
21+
; CHECK-SAME: i32 [[X:%.*]], i32 [[Y:%.*]]) {
22+
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[X]], 0
23+
; CHECK-NEXT: [[RES:%.*]] = select i1 [[CMP]], i32 [[Y]], i32 [[X]]
2124
; CHECK-NEXT: ret i32 [[RES]]
2225
;
2326
%cmp = icmp eq i32 %x, 0
@@ -28,10 +31,11 @@ define i32 @swap_operand_order(i32 %x, i32 %y) {
2831

2932
; Negative test: Non-zero false value in select
3033
define i32 @negative_non_zero_false_val(i32 %a, i32 %b) {
31-
; CHECK-LABEL: @negative_non_zero_false_val(
32-
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 0
33-
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], i32 [[B:%.*]], i32 1
34-
; CHECK-NEXT: [[OR:%.*]] = or i32 [[SEL]], [[A]]
34+
; CHECK-LABEL: define i32 @negative_non_zero_false_val(
35+
; CHECK-SAME: i32 [[A:%.*]], i32 [[B:%.*]]) {
36+
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A]], 0
37+
; CHECK-NEXT: [[TMP1:%.*]] = or i32 [[A]], 1
38+
; CHECK-NEXT: [[OR:%.*]] = select i1 [[CMP]], i32 [[B]], i32 [[TMP1]]
3539
; CHECK-NEXT: ret i32 [[OR]]
3640
;
3741
%cmp = icmp eq i32 %a, 0
@@ -42,10 +46,11 @@ define i32 @negative_non_zero_false_val(i32 %a, i32 %b) {
4246

4347
; Negative test: Incorrect comparison predicate (NE)
4448
define i32 @negative_wrong_predicate(i32 %a, i32 %b) {
45-
; CHECK-LABEL: @negative_wrong_predicate(
46-
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 0
47-
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], i32 0, i32 [[B:%.*]]
48-
; CHECK-NEXT: [[OR:%.*]] = or i32 [[SEL]], [[A]]
49+
; CHECK-LABEL: define i32 @negative_wrong_predicate(
50+
; CHECK-SAME: i32 [[A:%.*]], i32 [[B:%.*]]) {
51+
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A]], 0
52+
; CHECK-NEXT: [[TMP1:%.*]] = or i32 [[B]], [[A]]
53+
; CHECK-NEXT: [[OR:%.*]] = select i1 [[CMP]], i32 0, i32 [[TMP1]]
4954
; CHECK-NEXT: ret i32 [[OR]]
5055
;
5156
%cmp = icmp ne i32 %a, 0
@@ -56,9 +61,10 @@ define i32 @negative_wrong_predicate(i32 %a, i32 %b) {
5661

5762
; Comparison direction swap test (0 == X)
5863
define i32 @cmp_swapped(i32 %x, i32 %y) {
59-
; CHECK-LABEL: @cmp_swapped(
60-
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[X:%.*]], 0
61-
; CHECK-NEXT: [[RES:%.*]] = select i1 [[CMP]], i32 [[Y:%.*]], i32 [[X]]
64+
; CHECK-LABEL: define i32 @cmp_swapped(
65+
; CHECK-SAME: i32 [[X:%.*]], i32 [[Y:%.*]]) {
66+
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[X]], 0
67+
; CHECK-NEXT: [[RES:%.*]] = select i1 [[CMP]], i32 [[Y]], i32 [[X]]
6268
; CHECK-NEXT: ret i32 [[RES]]
6369
;
6470
%cmp = icmp eq i32 0, %x
@@ -69,10 +75,11 @@ define i32 @cmp_swapped(i32 %x, i32 %y) {
6975

7076
; Complex expression test
7177
define i32 @complex_expression(i32 %a, i32 %b) {
72-
; CHECK-LABEL: @complex_expression(
73-
; CHECK-NEXT: [[X:%.*]] = add i32 [[A:%.*]], 1
78+
; CHECK-LABEL: define i32 @complex_expression(
79+
; CHECK-SAME: i32 [[A:%.*]], i32 [[B:%.*]]) {
80+
; CHECK-NEXT: [[X:%.*]] = add i32 [[A]], 1
7481
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[X]], 0
75-
; CHECK-NEXT: [[RES:%.*]] = select i1 [[CMP]], i32 [[B:%.*]], i32 [[X]]
82+
; CHECK-NEXT: [[RES:%.*]] = select i1 [[CMP]], i32 [[B]], i32 [[X]]
7683
; CHECK-NEXT: ret i32 [[RES]]
7784
;
7885
%x = add i32 %a, 1
@@ -84,37 +91,42 @@ define i32 @complex_expression(i32 %a, i32 %b) {
8491

8592
; zext test
8693
define i32 @zext_cond(i8 %a, i32 %b) {
87-
; CHECK-LABEL: @zext_cond(
88-
; CHECK-NEXT: [[Z:%.*]] = zext i8 [[A:%.*]] to i32
94+
; CHECK-LABEL: define i32 @zext_cond(
95+
; CHECK-SAME: i8 [[A:%.*]], i32 [[B:%.*]]) {
96+
; CHECK-NEXT: [[Z:%.*]] = zext i8 [[A]] to i32
8997
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i8 [[A]], 0
90-
; CHECK-NEXT: [[OR:%.*]] = select i1 [[CMP]], i32 [[B:%.*]], i32 [[Z]]
98+
; CHECK-NEXT: [[OR:%.*]] = select i1 [[CMP]], i32 [[B]], i32 [[Z]]
9199
; CHECK-NEXT: ret i32 [[OR]]
92-
%z = zext i8 %a to i32
93-
%cmp = icmp eq i32 %z, 0
100+
;
101+
%z = zext i8 %a to i32
102+
%cmp = icmp eq i8 %a, 0
94103
%sel = select i1 %cmp, i32 %b, i32 0
95-
%or = or i32 %sel, %z
104+
%or = or i32 %sel, %z
96105
ret i32 %or
97106
}
98107

99108
; sext test
100109
define i32 @sext_cond(i8 %a, i32 %b) {
101-
; CHECK-LABEL: @sext_cond(
102-
; CHECK-NEXT: [[S:%.*]] = sext i8 [[A:%.*]] to i32
110+
; CHECK-LABEL: define i32 @sext_cond(
111+
; CHECK-SAME: i8 [[A:%.*]], i32 [[B:%.*]]) {
112+
; CHECK-NEXT: [[S:%.*]] = sext i8 [[A]] to i32
103113
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i8 [[A]], 0
104-
; CHECK-NEXT: [[OR:%.*]] = select i1 [[CMP]], i32 [[B:%.*]], i32 [[S]]
114+
; CHECK-NEXT: [[OR:%.*]] = select i1 [[CMP]], i32 [[B]], i32 [[S]]
105115
; CHECK-NEXT: ret i32 [[OR]]
106-
%s = sext i8 %a to i32
107-
%cmp = icmp eq i32 %s, 0
116+
;
117+
%s = sext i8 %a to i32
118+
%cmp = icmp eq i8 %a, 0
108119
%sel = select i1 %cmp, i32 %b, i32 0
109-
%or = or i32 %sel, %s
120+
%or = or i32 %sel, %s
110121
ret i32 %or
111122
}
112123

113124
; Vector type test
114125
define <2 x i32> @vector_type(<2 x i32> %a, <2 x i32> %b) {
115-
; CHECK-LABEL: @vector_type(
116-
; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], zeroinitializer
117-
; CHECK-NEXT: [[RES:%.*]] = select <2 x i1> [[CMP]], <2 x i32> [[B:%.*]], <2 x i32> [[A]]
126+
; CHECK-LABEL: define <2 x i32> @vector_type(
127+
; CHECK-SAME: <2 x i32> [[A:%.*]], <2 x i32> [[B:%.*]]) {
128+
; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i32> [[A]], zeroinitializer
129+
; CHECK-NEXT: [[RES:%.*]] = select <2 x i1> [[CMP]], <2 x i32> [[B]], <2 x i32> [[A]]
118130
; CHECK-NEXT: ret <2 x i32> [[RES]]
119131
;
120132
%cmp = icmp eq <2 x i32> %a, zeroinitializer
@@ -124,21 +136,42 @@ define <2 x i32> @vector_type(<2 x i32> %a, <2 x i32> %b) {
124136
}
125137

126138
; Pointer type test (should not trigger optimization)
127-
define i32* @pointer_type(i32* %p, i32* %q) {
128-
; CHECK-LABEL: @pointer_type(
129-
; CHECK-NEXT: [[A:%.*]] = ptrtoint ptr [[P:%.*]] to i64
139+
define ptr @pointer_type(ptr %p, ptr %q) {
140+
; CHECK-LABEL: define ptr @pointer_type(
141+
; CHECK-SAME: ptr [[P:%.*]], ptr [[Q:%.*]]) {
142+
; CHECK-NEXT: [[A:%.*]] = ptrtoint ptr [[P]] to i64
130143
; CHECK-NEXT: [[CMP:%.*]] = icmp eq ptr [[P]], null
131-
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], ptr [[Q:%.*]], ptr null
144+
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], ptr [[Q]], ptr null
132145
; CHECK-NEXT: [[SEL_INT:%.*]] = ptrtoint ptr [[SEL]] to i64
133146
; CHECK-NEXT: [[OR:%.*]] = or i64 [[A]], [[SEL_INT]]
134147
; CHECK-NEXT: [[RET:%.*]] = inttoptr i64 [[OR]] to ptr
135148
; CHECK-NEXT: ret ptr [[RET]]
136149
;
137-
%a = ptrtoint i32* %p to i64
150+
%a = ptrtoint ptr %p to i64
138151
%cmp = icmp eq i64 %a, 0
139-
%sel = select i1 %cmp, i32* %q, i32* null
140-
%sel_int = ptrtoint i32* %sel to i64
152+
%sel = select i1 %cmp, ptr %q, ptr null
153+
%sel_int = ptrtoint ptr %sel to i64
141154
%or_val = or i64 %a, %sel_int
142-
%ret = inttoptr i64 %or_val to i32*
143-
ret i32* %ret
155+
%ret = inttoptr i64 %or_val to ptr
156+
ret ptr %ret
144157
}
158+
159+
; Multi-use test (should not trigger optimization)
160+
define i32 @multi_use_test(i32 %x, i32 %m) {
161+
; CHECK-LABEL: define i32 @multi_use_test(
162+
; CHECK-SAME: i32 [[X:%.*]], i32 [[M:%.*]]) {
163+
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[X]], 0
164+
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], i32 [[M]], i32 0
165+
; CHECK-NEXT: [[OR:%.*]] = or i32 [[SEL]], [[X]]
166+
; CHECK-NEXT: [[ADD:%.*]] = add i32 [[SEL]], [[X]]
167+
; CHECK-NEXT: [[O2:%.*]] = sub i32 [[OR]], [[ADD]]
168+
; CHECK-NEXT: ret i32 [[O2]]
169+
;
170+
%cmp = icmp eq i32 %x, 0
171+
%sel = select i1 %cmp, i32 %m, i32 0
172+
%or = or i32 %sel, %x
173+
%add = add i32 %sel, %x
174+
%res = sub i32 %or, %add
175+
ret i32 %res
176+
}
177+

0 commit comments

Comments
 (0)