fix: use value_or

Nerixyz · Nerixyz · commit 5cb50cc62447 · 2025-08-08T21:06:31.000+02:00
diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp
@@ -894,9 +894,8 @@ PdbAstBuilder::CreateFunctionDecl(PdbCompilandSymId func_id,
       }
     }
 
-    ConstString mangled_name;
-    if (auto mangled_name_opt = pdb->FindMangledFunctionName(func_id))
-      mangled_name = ConstString(*mangled_name_opt);
+    ConstString mangled_name(
+        pdb->FindMangledFunctionName(func_id).value_or(llvm::StringRef()));
 
     if (!tag_record.FieldList.isSimple()) {
       CVType field_list_cvt = index.tpi().getType(tag_record.FieldList);

Original file line number	Diff line number	Diff line change
`@@ -894,9 +894,8 @@ PdbAstBuilder::CreateFunctionDecl(PdbCompilandSymId func_id,`
`894`	`894`	`}`
`895`	`895`	`}`
`896`	`896`
`897`		`- ConstString mangled_name;`
`898`		`- if (auto mangled_name_opt = pdb->FindMangledFunctionName(func_id))`
`899`		`- mangled_name = ConstString(*mangled_name_opt);`
	`897`	`+ ConstString mangled_name(`
	`898`	`+ pdb->FindMangledFunctionName(func_id).value_or(llvm::StringRef()));`
`900`	`899`
`901`	`900`	`if (!tag_record.FieldList.isSimple()) {`
`902`	`901`	`CVType field_list_cvt = index.tpi().getType(tag_record.FieldList);`