keep public api same

Author: grypp

mlir/include/mlir/IR/Remarks.h

@@ -408,6 +408,10 @@ class RemarkEngine {
   /// Emit all postponed remarks.
   void emitPostponedRemarks();
 
+  /// Report a remark. When `forcePrintPostponedRemarks` is true, the remark
+  /// will be printed even if it is postponed.
+  void report(const Remark &remark, bool forcePrintPostponedRemarks);
+
 public:
   /// Default constructor is deleted, use the other constructor.
   RemarkEngine() = delete;
@@ -426,7 +430,7 @@ class RemarkEngine {
                            std::string *errMsg);
 
   /// Report a remark.
-  void report(const Remark &remark, bool ignorePostpone = false);
+  void report(const Remark &remark);
 
   /// Report a successful remark, this will create an InFlightRemark
   /// that can be used to build the remark using the << operator.

mlir/lib/IR/Remarks.cpp

@@ -157,7 +157,7 @@ llvm::remarks::Remark Remark::generateRemark() const {
 
 InFlightRemark::~InFlightRemark() {
   if (remark && owner)
-    owner->report(std::move(*remark));
+    owner->report(*remark);
   owner = nullptr;
 }
 
@@ -225,9 +225,10 @@ InFlightRemark RemarkEngine::emitOptimizationRemarkAnalysis(Location loc,
 // RemarkEngine
 //===----------------------------------------------------------------------===//
 
-void RemarkEngine::report(const Remark &remark, bool ignorePostpone) {
+void RemarkEngine::report(const Remark &remark,
+                          bool forcePrintPostponedRemarks) {
   // Postponed remarks are shown at the end of pipeline, unless overridden.
-  if (remark.isPostponed() && !ignorePostpone) {
+  if (remark.isPostponed() && !forcePrintPostponedRemarks) {
     postponedRemarks.push_back(remark);
     return;
   }
@@ -241,9 +242,13 @@ void RemarkEngine::report(const Remark &remark, bool ignorePostpone) {
     emitRemark(remark.getLocation(), remark.getMsg());
 }
 
+void RemarkEngine::report(const Remark &remark) {
+  report(remark, /*forcePrintPostponedRemarks=*/false);
+}
+
 void RemarkEngine::emitPostponedRemarks() {
   for (auto &remark : postponedRemarks)
-    report(remark, /*ignorePostpone=*/true);
+    report(remark, /*forcePrintPostponedRemarks=*/true);
   postponedRemarks.clear();
 }