Skip to content

Commit 5614d36

Browse files
[llvm] Proofread HowToReleaseLLVM.rst (#163704)
1 parent 6870f68 commit 5614d36

File tree

1 file changed

+41
-41
lines changed

1 file changed

+41
-41
lines changed

llvm/docs/HowToReleaseLLVM.rst

Lines changed: 41 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ create the binary packages, please refer to the :doc:`ReleaseProcess` instead.
1818
Release Timeline
1919
================
2020

21-
LLVM is released on a time based schedule --- with major releases roughly
21+
LLVM is released on a time-based schedule --- with major releases roughly
2222
every 6 months. In between major releases there may be dot releases.
2323
The release manager will determine if and when to make a dot release based
2424
on feedback from the community. Typically, dot releases should be made if
25-
there are large number of bug-fixes in the stable branch or a critical bug
25+
there are a large number of bug fixes in the stable branch or a critical bug
2626
has been discovered that affects a large number of users.
2727

2828
Unless otherwise stated, dot releases will follow the same procedure as
@@ -73,7 +73,7 @@ Release Process Summary
7373

7474
* Generate and send out the second release candidate sources. Only *critical*
7575
bugs found during this testing phase will be fixed. Any bugs introduced by
76-
merged patches will be fixed. If so a third round of testing is needed.
76+
merged patches will be fixed. If so, a third round of testing is needed.
7777

7878
* The release notes are updated.
7979

@@ -107,15 +107,15 @@ Create Release Branch and Update LLVM Version
107107
Branch the Git trunk using the following procedure:
108108

109109
#. Remind developers that the release branching is imminent and to refrain from
110-
committing patches that might break the build. E.g., new features, large
110+
committing patches that might break the build, e.g., new features, large
111111
patches for works in progress, an overhaul of the type system, an exciting
112112
new TableGen feature, etc.
113113

114114
#. Verify that the current git trunk is in decent shape by
115115
examining nightly tester and buildbot results.
116116

117-
#. Bump the version in trunk to N.0.0git with the script in
118-
``llvm/utils/release/bump-version.py``, and tag the commit with llvmorg-N-init.
117+
#. Bump the version in trunk to ``N.0.0git`` with the script in
118+
``llvm/utils/release/bump-version.py``, and tag the commit with ``llvmorg-N-init``.
119119
If ``X`` is the version to be released, then ``N`` is ``X + 1``. ::
120120

121121
$ git tag -sa llvmorg-N-init
@@ -124,14 +124,14 @@ Branch the Git trunk using the following procedure:
124124
``llvm/utils/release/clear-release-notes.py``.
125125

126126
#. Create the release branch from the last known good revision from before the
127-
version bump. The branch's name is release/X.x where ``X`` is the major version
127+
version bump. The branch's name is ``release/X.x`` where ``X`` is the major version
128128
number and ``x`` is just the letter ``x``.
129129

130130
#. On the newly-created release branch, immediately bump the version
131-
to X.1.0git (where ``X`` is the major version of the branch.)
131+
to ``X.1.0git`` (where ``X`` is the major version of the branch.)
132132

133-
#. All tags and branches need to be created in both the llvm/llvm-project and
134-
llvm/llvm-test-suite repos.
133+
#. All tags and branches need to be created in both the ``llvm/llvm-project`` and
134+
``llvm/llvm-test-suite`` repos.
135135

136136
Tagging the LLVM Release Candidates
137137
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -157,7 +157,7 @@ the release page.
157157
$ for f in *.xz; do gh attestation verify --owner llvm $f && gpg -b $f; done
158158

159159
Tarballs, release binaries, or any other release artifacts must be uploaded to
160-
GitHub. This can be done using the github-upload-release.py script in utils/release.
160+
GitHub. This can be done using the ``github-upload-release.py`` script in ``utils/release``.
161161

162162
::
163163

@@ -170,25 +170,25 @@ Build The Binary Distribution
170170
Creating the binary distribution requires following the instructions
171171
:doc:`here <ReleaseProcess>`.
172172

173-
That process will perform both Release+Asserts and Release builds but only
174-
pack the Release build for upload. You should use the Release+Asserts sysroot,
173+
That process performs both Release+Asserts and Release builds but only packs
174+
the Release build for upload. You should use the Release+Asserts sysroot,
175175
normally under ``final/Phase3/Release+Asserts/llvmCore-3.8.1-RCn.install/``,
176-
for test-suite and run-time benchmarks, to make sure nothing serious has
176+
for test-suite and run-time benchmarks, to ensure nothing serious has
177177
passed through the net. For compile-time benchmarks, use the Release version.
178178

179179
The minimum required version of the tools you'll need are :doc:`here <GettingStarted>`
180180

181181
Release Qualification Criteria
182182
------------------------------
183183

184-
There are no official release qualification criteria. It is up to the
185-
the release manager to determine when a release is ready. The release manager
184+
There are no official release qualification criteria.
185+
The release manager determines when a release is ready. The release manager
186186
should pay attention to the results of community testing, the number of outstanding
187-
bugs, and then number of regressions when determining whether or not to make a
187+
bugs, and the number of regressions when determining whether or not to make a
188188
release.
189189

190190
The community values time based releases, so releases should not be delayed for
191-
too long unless there are critical issues remaining. In most cases, the only
191+
too long unless critical issues remain. In most cases, the only
192192
kind of bugs that are critical enough to block a release would be a major regression
193193
from a previous release.
194194

@@ -199,33 +199,33 @@ A few developers in the community have dedicated time to validate the release
199199
candidates and volunteered to be the official release testers for each
200200
architecture.
201201

202-
These will be the ones testing, generating and uploading the official binaries
202+
These will be the ones testing, generating, and uploading the official binaries
203203
to the server, and will be the minimum tests *necessary* for the release to
204204
proceed.
205205

206206
This will obviously not cover all OSs and distributions, so additional community
207-
validation is important. However, if community input is not reached before the
208-
release is out, all bugs reported will have to go on the next stable release.
207+
validation is important. However, if community input is not received before the
208+
release, all reported bugs will be deferred to the next stable release.
209209

210210
The official release managers are:
211211

212212
* Even releases: Tom Stellard ([email protected])
213213
* Odd releases: Tobias Hieta ([email protected])
214214

215-
The official release testers are volunteered from the community and have
215+
The official release testers are volunteers from the community who have
216216
consistently validated and released binaries for their targets/OSs. To contact
217217
them, you should post on the `Discourse forums (Project
218218
Infrastructure - Release Testers). <https://discourse.llvm.org/c/infrastructure/release-testers/66>`_
219219

220-
The official testers list is in the file `RELEASE_TESTERS.TXT
220+
The official testers list is in the file ``RELEASE_TESTERS.TXT``
221221
<https://github.com/llvm/llvm-project/blob/main/llvm/RELEASE_TESTERS.TXT>`_, in
222222
the LLVM repository.
223223

224224
Community Testing
225225
-----------------
226226

227-
Once all testing has been completed and appropriate bugs filed, the release
228-
candidate tarballs are put on the website and the LLVM community is notified.
227+
Once all testing is complete and appropriate bugs are filed, the release
228+
candidate tarballs are put on the website, and the LLVM community is notified.
229229

230230
We ask that all LLVM developers test the release in any the following ways:
231231

@@ -251,7 +251,7 @@ We ask that all LLVM developers test the release in any the following ways:
251251
architecture.
252252

253253
We also ask that the OS distribution release managers test their packages with
254-
the first candidate of every release, and report any *new* errors in GitHub.
254+
the first candidate of every release and report any *new* errors in GitHub.
255255
If the bug can be reproduced with an unpatched upstream version of the release
256256
candidate (as opposed to the distribution's own build), the priority should be
257257
release blocker.
@@ -268,10 +268,10 @@ next stage.
268268
Reporting Regressions
269269
---------------------
270270

271-
Every regression that is found during the tests (as per the criteria above),
271+
Every regression found during the tests (as per the criteria above)
272272
should be filled in a bug in GitHub and added to the release milestone.
273273

274-
If a bug can't be reproduced, or stops being a blocker, it should be removed
274+
If a bug can't be reproduced or stops being a blocker, it should be removed
275275
from the Milestone. Debugging can continue, but on trunk.
276276

277277
Backport Requests
@@ -299,15 +299,15 @@ This section describes how to triage bug reports:
299299
to see the list of bugs that are being considered for the release.
300300

301301
#. Review each bug and first check if it has been fixed in main. If it has, update
302-
its status to "Needs Pull Request", and create a pull request for the fix
303-
using the /cherry-pick or /branch comments if this has not been done already.
302+
its status to "Needs Pull Request" and create a pull request for the fix
303+
using the ``/cherry-pick`` or ``/branch`` comments if this has not been done already.
304304

305305
#. If a bug has been fixed and has a pull request created for backporting it,
306306
then update its status to "Needs Review" and notify a knowledgeable
307307
reviewer. Usually you will want to notify the person who approved the
308308
patch, but you may use your best judgement on who a good reviewer would be.
309309
Once you have identified the reviewer(s), assign the issue to them and
310-
mention them (i.e @username) in a comment and ask them if the patch is safe
310+
mention them (i.e., ``@username``) in a comment and ask them if the patch is safe
311311
to backport. You should also review the bug yourself to ensure that it
312312
meets the requirements for committing to the release branch.
313313

@@ -323,11 +323,11 @@ Release Patch Rules
323323
Below are the rules regarding patching the release branch:
324324

325325
#. Patches applied to the release branch may only be applied by the release
326-
manager, the official release testers or the maintainers with approval from
326+
manager, the official release testers, or the maintainers with approval from
327327
the release manager.
328328

329329
#. Release managers are encouraged, but not required, to get approval from a
330-
maintainer before approving patches. If there are no reachable maintainers
330+
maintainer before approving patches. If there are no reachable maintainers,
331331
then release managers can ask approval from patch reviewers or other
332332
developers active in that area.
333333

@@ -336,7 +336,7 @@ Below are the rules regarding patching the release branch:
336336
was created. As with all phases, release managers and maintainers can reject
337337
patches that are deemed too invasive.
338338

339-
#. *Before RC2/RC3* Patches should be limited to bug fixes or backend specific
339+
#. *Before RC2/RC3* Patches should be limited to bug fixes or backend-specific
340340
improvements that are determined to be very safe.
341341

342342
#. *Before Final Major Release* Patches should be limited to critical
@@ -349,7 +349,7 @@ Below are the rules regarding patching the release branch:
349349
Release Final Tasks
350350
-------------------
351351

352-
The final stages of the release process involves tagging the "final" release
352+
The final stages of the release process involve tagging the "final" release
353353
branch, updating documentation that refers to the release, and updating the
354354
demo page.
355355

@@ -394,11 +394,11 @@ is what to do:
394394
#. Update the ``releases/index.html`` with the new release and link to release
395395
documentation.
396396

397-
#. After you push the changes to the www-releases repo, someone with admin
398-
access must login to prereleases-origin.llvm.org and manually pull the new
399-
changes into /data/www-releases/. This is where the website is served from.
397+
#. After you push the changes to the ``www-releases`` repo, someone with admin
398+
access must log in to ``prereleases-origin.llvm.org`` and manually pull the new
399+
changes into ``/data/www-releases/``. This is where the website is served from.
400400

401-
#. Finally checkout the llvm-www repo and update the main page
401+
#. Finally, check out the ``llvm-www`` repo and update the main page
402402
(``index.html`` and sidebar) to point to the new release and release
403403
announcement.
404404

@@ -414,5 +414,5 @@ using this command and add it to the post.
414414

415415
$ git log --format="- %aN: [%s (%h)](https://github.com/llvm/llvm-project/commit/%H)" llvmorg-X.1.N-1..llvmorg-X.1.N
416416

417-
Once the release has been announced add a link to the announcement on the llvm
418-
homepage (from the llvm-www repo) in the "Release Emails" section.
417+
Once the release has been announced, add a link to the announcement on the llvm
418+
homepage (from the ``llvm-www`` repo) in the "Release Emails" section.

0 commit comments

Comments
 (0)