Skip to content

Commit 4c992de

Browse files
committed
add a comment
Signed-off-by: hanhanW <[email protected]>
1 parent a4ed7d8 commit 4c992de

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -911,7 +911,9 @@ struct PackOpTiling
911911

912912
// If a dimension is not tiled, it is always valid to fuse the pack op,
913913
// even if the op has padding semantics. Because it always generates a
914-
// full slice along the dimension.
914+
// full slice along the dimension. The tile sizes are for unpacked
915+
// domain, i.e., `srcDimSize`, so `tileSize < srcDimSize` means no
916+
// tiling at all.
915917
// TODO: It could be untiled if the `srcDimSize` is dynamic. It is a
916918
// hard check to determine if a dimension is tiled or not.
917919
int64_t srcDimSize = packOp.getSourceType().getDimSize(dim);

0 commit comments

Comments
 (0)