WIP: fix assert in hasInitWithSideEffects

Author: hnrklssn

clang/lib/AST/Decl.cpp

@@ -2444,20 +2444,14 @@ bool VarDecl::hasInitWithSideEffects() const {
   if (!hasInit())
     return false;
 
-  // Check if we can get the initializer without deserializing
-  const Expr *E = nullptr;
+  // Check if we can get the initializer directly without an external source
   if (auto *S = dyn_cast<Stmt *>(Init)) {
-    E = cast<Expr>(S);
-  } else {
-    E = cast_or_null<Expr>(getEvaluatedStmt()->Value.getWithoutDeserializing());
-  }
-
-  if (E)
+    const Expr *E = cast<Expr>(S);
     return E->HasSideEffects(getASTContext()) &&
            // We can get a value-dependent initializer during error recovery.
            (E->isValueDependent() || !evaluateValue());
+  }
 
-  assert(getEvaluatedStmt()->Value.isOffset());
   // ASTReader tracks this without having to deserialize the initializer
   if (auto Source = getASTContext().getExternalSource())
     return Source->hasInitializerWithSideEffects(this);