Improve loop over getAllArgValues

bd1976bris · bd1976bris · commit 44fdeb9e11f1 · 2025-09-11T17:02:50.000+01:00
diff --git a/clang/lib/Driver/ToolChains/CommonArgs.cpp b/clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -1352,7 +1352,7 @@ void tools::addLTOOptions(const ToolChain &ToolChain, const ArgList &Args,
         Args.MakeArgString("--thinlto-remote-compiler=" +
                            Twine(ToolChain.getDriver().getClangProgramPath())));
 
-    for (auto A : Args.getAllArgValues(options::OPT_Xthinlto_distributor_EQ))
+    for (auto &A : Args.getAllArgValues(options::OPT_Xthinlto_distributor_EQ))
       CmdArgs.push_back(Args.MakeArgString("--thinlto-distributor-arg=" + A));
   }
 }
diff --git a/clang/lib/Driver/ToolChains/PS4CPU.cpp b/clang/lib/Driver/ToolChains/PS4CPU.cpp
@@ -350,7 +350,7 @@ void tools::PS5cpu::Linker::ConstructJob(Compilation &C, const JobAction &JA,
     CmdArgs.push_back(Args.MakeArgString("--thinlto-remote-compiler=" +
                                          Twine(D.getClangProgramPath())));
 
-    for (auto A : Args.getAllArgValues(options::OPT_Xthinlto_distributor_EQ))
+    for (auto &A : Args.getAllArgValues(options::OPT_Xthinlto_distributor_EQ))
       CmdArgs.push_back(Args.MakeArgString("--thinlto-distributor-arg=" + A));
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1352,7 +1352,7 @@ void tools::addLTOOptions(const ToolChain &ToolChain, const ArgList &Args,`
`1352`	`1352`	`Args.MakeArgString("--thinlto-remote-compiler=" +`
`1353`	`1353`	`Twine(ToolChain.getDriver().getClangProgramPath())));`
`1354`	`1354`
`1355`		`- for (auto A : Args.getAllArgValues(options::OPT_Xthinlto_distributor_EQ))`
	`1355`	`+ for (auto &A : Args.getAllArgValues(options::OPT_Xthinlto_distributor_EQ))`
`1356`	`1356`	`CmdArgs.push_back(Args.MakeArgString("--thinlto-distributor-arg=" + A));`
`1357`	`1357`	`}`
`1358`	`1358`	`}`
Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ void tools::PS5cpu::Linker::ConstructJob(Compilation &C, const JobAction &JA,`
`350`	`350`	`CmdArgs.push_back(Args.MakeArgString("--thinlto-remote-compiler=" +`
`351`	`351`	`Twine(D.getClangProgramPath())));`
`352`	`352`
`353`		`- for (auto A : Args.getAllArgValues(options::OPT_Xthinlto_distributor_EQ))`
	`353`	`+ for (auto &A : Args.getAllArgValues(options::OPT_Xthinlto_distributor_EQ))`
`354`	`354`	`CmdArgs.push_back(Args.MakeArgString("--thinlto-distributor-arg=" + A));`
`355`	`355`	`}`
`356`	`356`