Skip to content

Commit 415cb8f

Browse files
committed
Improve comments
1 parent 12ce70e commit 415cb8f

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -295,18 +295,19 @@ static void ConnectEpilog(Loop *L, Value *ModVal, BasicBlock *NewExit,
295295
// EpilogPreHeader is the right incoming block for VPN, as set below?
296296
// TODO: Can we thus avoid the enclosing loop over successors?
297297
assert(Succ == L->getHeader() &&
298-
"Expect only non-loop successor of latch to be header");
298+
"Expect the only in-loop successor of latch to be the loop header");
299299

300300
for (PHINode &PN : Succ->phis()) {
301301
// Add new PHI nodes to the loop exit block.
302-
PHINode *NewPN0 = PHINode::Create(PN.getType(), 1, PN.getName() + ".unr");
302+
PHINode *NewPN0 = PHINode::Create(PN.getType(), /*NumReservedValues=*/1,
303+
PN.getName() + ".unr");
303304
NewPN0->insertBefore(NewExit->getFirstNonPHIIt());
304305
// Add value to the new PHI node from the unrolling loop latch.
305306
NewPN0->addIncoming(PN.getIncomingValueForBlock(Latch), Latch);
306307

307308
// Add new PHI nodes to EpilogPreHeader.
308-
PHINode *NewPN1 =
309-
PHINode::Create(PN.getType(), 2, PN.getName() + ".epil.init");
309+
PHINode *NewPN1 = PHINode::Create(PN.getType(), /*NumReservedValues=*/2,
310+
PN.getName() + ".epil.init");
310311
NewPN1->insertBefore(EpilogPreHeader->getFirstNonPHIIt());
311312
// Add value to the new PHI node from the unrolling loop preheader.
312313
NewPN1->addIncoming(PN.getIncomingValueForBlock(NewPreHeader), PreHeader);

0 commit comments

Comments
 (0)