[mlir][spirv] Fix incorrect metadata in SPIR-V Header (#104242)

AmrDeveloper · web-flow · commit 3b80a28c8f27 · 2024-08-19T14:58:06.000-04:00
SRIP-V Generator Magic Number is a 32 bit word: The high order 16 bits are a tool ID. The low order 16 bits are for verion number, currently the tool id is not on the high order 16 bit so it must shifed fixes: #99071
diff --git a/mlir/lib/Target/SPIRV/SPIRVBinaryUtils.cpp b/mlir/lib/Target/SPIRV/SPIRVBinaryUtils.cpp
@@ -52,7 +52,7 @@ void spirv::appendModuleHeader(SmallVectorImpl<uint32_t> &header,
   // +-------------------------------------------------------------------------+
   header.push_back(spirv::kMagicNumber);
   header.push_back((majorVersion << 16) | (minorVersion << 8));
-  header.push_back(kGeneratorNumber);
+  header.push_back((kGeneratorNumber << 16) | LLVM_VERSION_MAJOR);
   header.push_back(idBound); // <id> bound
   header.push_back(0);       // Schema (reserved word)
 }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ void spirv::appendModuleHeader(SmallVectorImpl<uint32_t> &header,`
`52`	`52`	`// +-------------------------------------------------------------------------+`
`53`	`53`	`header.push_back(spirv::kMagicNumber);`
`54`	`54`	`header.push_back((majorVersion << 16) \| (minorVersion << 8));`
`55`		`- header.push_back(kGeneratorNumber);`
	`55`	`+ header.push_back((kGeneratorNumber << 16) \| LLVM_VERSION_MAJOR);`
`56`	`56`	`header.push_back(idBound); // <id> bound`
`57`	`57`	`header.push_back(0); // Schema (reserved word)`
`58`	`58`	`}`