[TableGen] Remove unnecessary sortAndUniqueRegisters (#149125)

jayfoad · web-flow · commit 362594a10fa5 · 2025-07-16T20:27:50.000+01:00
Each of the SRSets is already sorted and unique because it is a filtered
version of RC-&gt;getMembers() which is already sorted and unique.
diff --git a/llvm/utils/TableGen/Common/CodeGenRegisters.cpp b/llvm/utils/TableGen/Common/CodeGenRegisters.cpp
@@ -2295,9 +2295,6 @@ void CodeGenRegBank::inferSubClassWithSubReg(CodeGenRegisterClass *RC) {
       SRSets[I].push_back(R);
   }
 
-  for (auto I : SRSets)
-    sortAndUniqueRegisters(I.second);
-
   // Find matching classes for all SRSets entries.  Iterate in SubRegIndex
   // numerical order to visit synthetic indices last.
   for (const CodeGenSubRegIndex &SubIdx : SubRegIndices) {

Original file line number	Diff line number	Diff line change
`@@ -2295,9 +2295,6 @@ void CodeGenRegBank::inferSubClassWithSubReg(CodeGenRegisterClass *RC) {`
`2295`	`2295`	`SRSets[I].push_back(R);`
`2296`	`2296`	`}`
`2297`	`2297`
`2298`		`- for (auto I : SRSets)`
`2299`		`- sortAndUniqueRegisters(I.second);`
`2300`		`-`
`2301`	`2298`	`// Find matching classes for all SRSets entries. Iterate in SubRegIndex`
`2302`	`2299`	`// numerical order to visit synthetic indices last.`
`2303`	`2300`	`for (const CodeGenSubRegIndex &SubIdx : SubRegIndices) {`