Skip to content

Commit 2fd7d36

Browse files
committed
[libc++] Make the verify-support feature implicit
Tests that require support for Clang-verify are already marked as such explicitly by their extension, which is .verify.cpp. Requiring the use of an explicit Lit feature is, after thought, not really helpful. This is a change in design: we have been bitten in the past by tests not being enabled when we thought they were. However, the issue was mostly with file extensions being ignored. The fix for that is not to blindly require explicit features all the time, but instead to report all files that are in the suite but that don't match any known test format. This can be implemented in a follow-up patch.
1 parent bd3058e commit 2fd7d36

File tree

84 files changed

+27
-155
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

84 files changed

+27
-155
lines changed

libcxx/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.depr_in_cxx14.verify.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
// UNSUPPORTED: clang-4.0
2121
// UNSUPPORTED: c++98, c++03, c++11
22-
// REQUIRES: verify-support
2322

2423
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE
2524

libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// when -fdelayed-template-parsing is enabled, like it is on Windows.
1111
// XFAIL: LIBCXX-WINDOWS-FIXME
1212

13-
// REQUIRES: verify-support, diagnose-if-support
13+
// REQUIRES: diagnose-if-support
1414
// UNSUPPORTED: libcpp-has-no-threads
1515

1616
// <atomic>

libcxx/test/libcxx/containers/associative/non_const_comparator.incomplete.verify.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
//===----------------------------------------------------------------------===//
88

99
// UNSUPPORTED: c++98, c++03
10-
// REQUIRES: verify-support
1110

1211
// Test that libc++ does not generate a warning diagnostic about the comparator
1312
// too early for containers of incomplete types.

libcxx/test/libcxx/containers/associative/non_const_comparator.verify.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//===----------------------------------------------------------------------===//
88

99
// UNSUPPORTED: c++98, c++03
10-
// REQUIRES: diagnose-if-support, verify-support
10+
// REQUIRES: diagnose-if-support
1111

1212
// Test that libc++ generates a warning diagnostic when the container is
1313
// provided a non-const callable comparator.

libcxx/test/libcxx/containers/unord/non_const_comparator.incomplete.verify.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
//===----------------------------------------------------------------------===//
88

99
// UNSUPPORTED: c++98, c++03
10-
// REQUIRES: verify-support
1110

1211
// Test that libc++ does not generate a warning diagnostic about the comparator
1312
// or the hasher too early for containers of incomplete types.

libcxx/test/libcxx/containers/unord/non_const_comparator.verify.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//===----------------------------------------------------------------------===//
88

99
// UNSUPPORTED: c++98, c++03
10-
// REQUIRES: diagnose-if-support, verify-support
10+
// REQUIRES: diagnose-if-support
1111

1212
// Test that libc++ generates a warning diagnostic when the container is
1313
// provided a non-const callable comparator or a non-const hasher.

libcxx/test/libcxx/depr/depr.auto.ptr/auto.ptr/auto_ptr.depr_in_cxx11.verify.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
// UNSUPPORTED: clang-4.0
2222
// UNSUPPORTED: c++98, c++03
23-
// REQUIRES: verify-support
2423

2524
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_CXX17_REMOVED_AUTO_PTR
2625

libcxx/test/libcxx/depr/depr.c.headers/no_fgetpos_fsetpos.verify.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// REQUIRES: verify-support
109
// UNSUPPORTED: c++98 || c++03
1110

1211
#include <cstdio>

libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/address.depr_in_cxx17.verify.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
// Deprecated in C++17
1616

1717
// UNSUPPORTED: c++98, c++03, c++11, c++14
18-
// REQUIRES: verify-support
1918

2019
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS
2120

libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.cxx2a.verify.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
//===----------------------------------------------------------------------===//
88

99
// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
10-
// REQUIRES: verify-support
1110

1211
// <memory>
1312

0 commit comments

Comments
 (0)