[Clang] FunctionEffects: ignore (methods of) local CXXRecordDecls.

Author: Doug Wyatt

clang/lib/Sema/SemaFunctionEffects.cpp

@@ -1286,6 +1286,14 @@ class Analyzer {
       return true;
     }
 
+    bool TraverseCXXRecordDecl(CXXRecordDecl *D) override {
+      // Completely skip local struct/class/union declarations since their
+      // methods would otherwise be incorrectly interpreted as part of the
+      // function we are currently traversing. The initial Sema pass will have
+      // already recorded any nonblocking methods needing analysis.
+      return true;
+    }
+
     bool TraverseConstructorInitializer(CXXCtorInitializer *Init) override {
       ViolationSite PrevVS = VSite;
       if (Init->isAnyMemberInitializer())

clang/test/Sema/attr-nonblocking-constraints.cpp

@@ -104,6 +104,15 @@ void nb8c()
 	};
 }
 
+void nb8d() [[clang::nonblocking]]
+{
+	// Blocking methods of a local CXXRecordDecl do not generate diagnostics
+	// for the outer function.
+	struct Functor1 {
+        void method() { void* ptr = new int; }
+	};
+}
+
 // Make sure template expansions are found and verified.
 	template <typename T>
 	struct Adder {