turn off AdbClientTest.RealTcpConnection on windows to fix build breakage

cs01 · cs01 · commit 1cf334654c28 · 2025-09-25T13:40:58.000-07:00
diff --git a/lldb/unittests/Platform/Android/AdbClientTest.cpp b/lldb/unittests/Platform/Android/AdbClientTest.cpp
@@ -108,6 +108,9 @@ static uint16_t FindUnusedPort() {
   return port;
 }
 
+#ifndef _WIN32
+// This test is disabled on Windows due to platform-specific socket behavior
+// that causes assertion failures in TCPSocket::Listen()
 TEST_F(AdbClientTest, RealTcpConnection) {
   uint16_t unused_port = FindUnusedPort();
   ASSERT_NE(unused_port, 0) << "Failed to find an unused port";
@@ -137,3 +140,4 @@ TEST_F(AdbClientTest, RealTcpConnection) {
       << "Connection should succeed when server is listening on port "
       << unused_port;
 }
+#endif // _WIN32

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,9 @@ static uint16_t FindUnusedPort() {`
`108`	`108`	`return port;`
`109`	`109`	`}`
`110`	`110`
	`111`	`+#ifndef _WIN32`
	`112`	`+// This test is disabled on Windows due to platform-specific socket behavior`
	`113`	`+// that causes assertion failures in TCPSocket::Listen()`
`111`	`114`	`TEST_F(AdbClientTest, RealTcpConnection) {`
`112`	`115`	`uint16_t unused_port = FindUnusedPort();`
`113`	`116`	`ASSERT_NE(unused_port, 0) << "Failed to find an unused port";`
`@@ -137,3 +140,4 @@ TEST_F(AdbClientTest, RealTcpConnection) {`
`137`	`140`	`<< "Connection should succeed when server is listening on port "`
`138`	`141`	`<< unused_port;`
`139`	`142`	`}`
	`143`	`+#endif // _WIN32`