Skip to content

Commit 1c82dd3

Browse files
[MLIR] Ensure that target_link_libraries() always has a keyword.
CMake allows calling target_link_libraries() without a keyword, but this usage is not preferred when also called with a keyword, and has surprising behavior. This patch explicitly specifies a keyword when using target_link_libraries(). Differential Revision: https://reviews.llvm.org/D75725
1 parent fc6fda9 commit 1c82dd3

File tree

54 files changed

+148
-36
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+148
-36
lines changed

mlir/lib/Analysis/CMakeLists.txt

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ add_dependencies(MLIRAnalysis
3333
MLIRLoopOps
3434
)
3535

36-
target_link_libraries(MLIRAnalysis MLIRAffineOps MLIRLoopOps)
36+
target_link_libraries(MLIRAnalysis
37+
PUBLIC
38+
MLIRAffineOps
39+
MLIRLoopOps
40+
)
3741

3842
add_llvm_library(MLIRLoopAnalysis
3943
AffineAnalysis.cpp
@@ -53,4 +57,7 @@ add_dependencies(MLIRLoopAnalysis
5357
MLIRLoopOps
5458
)
5559

56-
target_link_libraries(MLIRLoopAnalysis MLIRAffineOps MLIRLoopOps)
60+
target_link_libraries(MLIRLoopAnalysis
61+
PUBLIC
62+
MLIRAffineOps
63+
MLIRLoopOps)

mlir/lib/Conversion/AffineToStandard/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ add_dependencies(
1515
)
1616
target_link_libraries(
1717
MLIRAffineToStandard
18-
18+
PUBLIC
1919
MLIRAffineOps
2020
MLIRLoopOps
2121
MLIRPass

mlir/lib/Conversion/GPUToCUDA/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ endif()
1212

1313
add_mlir_conversion_library(MLIRGPUtoCUDATransforms ${SOURCES})
1414
target_link_libraries(MLIRGPUtoCUDATransforms
15+
PUBLIC
1516
MLIRGPU
1617
MLIRLLVMIR
1718
MLIRNVVMIR

mlir/lib/Conversion/GPUToNVVM/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ add_dependencies(MLIRGPUtoNVVMTransforms
1010
MLIRGPUToNVVMIncGen)
1111

1212
target_link_libraries(MLIRGPUtoNVVMTransforms
13+
PUBLIC
1314
LLVMSupport
1415
MLIRGPU
1516
MLIRLLVMIR

mlir/lib/Conversion/GPUToROCDL/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ add_mlir_conversion_library(MLIRGPUtoROCDLTransforms
22
LowerGpuOpsToROCDLOps.cpp
33
)
44
target_link_libraries(MLIRGPUtoROCDLTransforms
5+
PUBLIC
56
LLVMSupport
67
MLIRGPU
78
MLIRLLVMIR

mlir/lib/Conversion/GPUToSPIRV/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ add_dependencies(MLIRGPUtoSPIRVTransforms
1111
MLIRGPUToSPIRVIncGen)
1212

1313
target_link_libraries(MLIRGPUtoSPIRVTransforms
14+
PUBLIC
1415
MLIRGPU
1516
MLIRIR
1617
MLIRPass

mlir/lib/Conversion/GPUToVulkan/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ add_mlir_conversion_library(MLIRGPUtoVulkanTransforms
33
)
44

55
target_link_libraries(MLIRGPUtoVulkanTransforms
6+
PUBLIC
67
MLIRGPU
78
MLIRIR
89
MLIRLLVMIR

mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,6 @@ set(LIBS
1919
)
2020

2121
add_dependencies(MLIRLinalgToLLVM ${LIBS})
22-
target_link_libraries(MLIRLinalgToLLVM ${LIBS})
22+
target_link_libraries(MLIRLinalgToLLVM
23+
PUBLIC
24+
${LIBS})

mlir/lib/Conversion/LinalgToSPIRV/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ add_mlir_conversion_library(MLIRLinalgToSPIRVTransforms
88
)
99

1010
target_link_libraries(MLIRLinalgToSPIRVTransforms
11+
PUBLIC
1112
MLIRIR
1213
MLIRLinalgOps
1314
MLIRLinalgUtils

mlir/lib/Conversion/LoopToStandard/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ add_dependencies(
1414
)
1515
target_link_libraries(
1616
MLIRLoopToStandard
17-
17+
PUBLIC
1818
MLIRLoopOps
1919
MLIRTransforms
2020
LLVMCore

0 commit comments

Comments
 (0)