Optimize -Wunsafe-buffer-usage.

Author: ivanaivanovska

clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def

@@ -18,10 +18,14 @@
 #define WARNING_GADGET(name) GADGET(name)
 #endif
 
-/// A `WARNING_GADGET` subset, each of which may be enable/disable separately
-/// with different flags
-#ifndef WARNING_OPTIONAL_GADGET
-#define WARNING_OPTIONAL_GADGET(name) WARNING_GADGET(name)
+/// A `WARNING_GADGET` subset, accepts context as additional parameter.
+#ifndef WARNING_OPTIONAL_GADGET_CTX
+#define WARNING_OPTIONAL_GADGET_CTX(name) WARNING_GADGET(name)
+#endif
+
+/// A `WARNING_GADGET` subset, accepts handler as additional parameter.
+#ifndef WARNING_OPTIONAL_GADGET_HANDLER
+#define WARNING_OPTIONAL_GADGET_HANDLER(name) WARNING_GADGET(name)
 #endif
 
 /// Safe gadgets correspond to code patterns that aren't unsafe but need to be
@@ -31,27 +35,34 @@
 #define FIXABLE_GADGET(name) GADGET(name)
 #endif
 
+/// A subset of the safe gadgets that may return multiple results.
+#ifndef FIXABLE_GADGET_MULTY_RES
+#define FIXABLE_GADGET_MULTY_RES(name) GADGET(name)
+#endif
+
 WARNING_GADGET(Increment)
 WARNING_GADGET(Decrement)
-WARNING_GADGET(ArraySubscript)
 WARNING_GADGET(PointerArithmetic)
 WARNING_GADGET(UnsafeBufferUsageAttr)
-WARNING_GADGET(UnsafeBufferUsageCtorAttr)
 WARNING_GADGET(DataInvocation)
-WARNING_OPTIONAL_GADGET(UnsafeLibcFunctionCall)
-WARNING_OPTIONAL_GADGET(SpanTwoParamConstructor) // Uses of `std::span(arg0, arg1)`
+WARNING_OPTIONAL_GADGET_CTX(ArraySubscript)
+WARNING_OPTIONAL_GADGET_CTX(UnsafeBufferUsageCtorAttr)
+WARNING_OPTIONAL_GADGET_HANDLER(UnsafeLibcFunctionCall)
+WARNING_OPTIONAL_GADGET_HANDLER(SpanTwoParamConstructor) // Uses of `std::span(arg0, arg1)`
 FIXABLE_GADGET(ULCArraySubscript)          // `DRE[any]` in an Unspecified Lvalue Context
 FIXABLE_GADGET(DerefSimplePtrArithFixable)
 FIXABLE_GADGET(PointerDereference)
-FIXABLE_GADGET(UPCAddressofArraySubscript) // '&DRE[any]' in an Unspecified Pointer Context
-FIXABLE_GADGET(UPCStandalonePointer)
-FIXABLE_GADGET(UPCPreIncrement)            // '++Ptr' in an Unspecified Pointer Context
-FIXABLE_GADGET(UUCAddAssign)            // 'Ptr += n' in an Unspecified Untyped Context
-FIXABLE_GADGET(PtrToPtrAssignment)
-FIXABLE_GADGET(CArrayToPtrAssignment)
+FIXABLE_GADGET_MULTY_RES(UPCAddressofArraySubscript) // '&DRE[any]' in an Unspecified Pointer Context
+FIXABLE_GADGET_MULTY_RES(UPCStandalonePointer)
+FIXABLE_GADGET_MULTY_RES(UPCPreIncrement)            // '++Ptr' in an Unspecified Pointer Context
+FIXABLE_GADGET_MULTY_RES(UUCAddAssign)            // 'Ptr += n' in an Unspecified Untyped Context
+FIXABLE_GADGET_MULTY_RES(PtrToPtrAssignment)
+FIXABLE_GADGET_MULTY_RES(CArrayToPtrAssignment)
 FIXABLE_GADGET(PointerInit)
 
+#undef FIXABLE_GADGET_MULTY_RES
 #undef FIXABLE_GADGET
 #undef WARNING_GADGET
-#undef WARNING_OPTIONAL_GADGET
+#undef WARNING_OPTIONAL_GADGET_CTX
+#undef WARNING_OPTIONAL_GADGET_HANDLER
 #undef GADGET