Skip to content

Commit 1a93285

Browse files
committed
Fix -Wstring-compare warnings in new OpenMP code
1 parent 859654c commit 1a93285

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

llvm/lib/Frontend/OpenMP/OMPContext.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ bool llvm::omp::isValidTraitPropertyForTraitSetAndSelector(
411411
std::string llvm::omp::listOpenMPContextTraitSets() {
412412
std::string S;
413413
#define OMP_TRAIT_SET(Enum, Str) \
414-
if (Str != "invalid") \
414+
if (StringRef(Str) != "invalid") \
415415
S.append("'").append(Str).append("'").append(" ");
416416
#include "llvm/Frontend/OpenMP/OMPKinds.def"
417417
S.pop_back();
@@ -421,7 +421,7 @@ std::string llvm::omp::listOpenMPContextTraitSets() {
421421
std::string llvm::omp::listOpenMPContextTraitSelectors(TraitSet Set) {
422422
std::string S;
423423
#define OMP_TRAIT_SELECTOR(Enum, TraitSetEnum, Str, ReqProp) \
424-
if (TraitSet::TraitSetEnum == Set && Str != "Invalid") \
424+
if (TraitSet::TraitSetEnum == Set && StringRef(Str) != "Invalid") \
425425
S.append("'").append(Str).append("'").append(" ");
426426
#include "llvm/Frontend/OpenMP/OMPKinds.def"
427427
S.pop_back();
@@ -434,7 +434,8 @@ llvm::omp::listOpenMPContextTraitProperties(TraitSet Set,
434434
std::string S;
435435
#define OMP_TRAIT_PROPERTY(Enum, TraitSetEnum, TraitSelectorEnum, Str) \
436436
if (TraitSet::TraitSetEnum == Set && \
437-
TraitSelector::TraitSelectorEnum == Selector && Str != "invalid") \
437+
TraitSelector::TraitSelectorEnum == Selector && \
438+
StringRef(Str) != "invalid") \
438439
S.append("'").append(Str).append("'").append(" ");
439440
#include "llvm/Frontend/OpenMP/OMPKinds.def"
440441
S.pop_back();

0 commit comments

Comments
 (0)