resolve comments

Author: mingmingl-llvm

lld/ELF/InputFiles.cpp

@@ -1807,8 +1807,7 @@ void BitcodeFile::parseLazy() {
     } else {
       // Keep copies of per-module undefined symbols for LTO::GlobalResolutions
       // usage.
-      [[maybe_unused]] StringRef SymbolRef =
-          unique_saver().save(irSym.getName());
+      unique_saver().save(irSym.getName());
     }
 }
 

llvm/include/llvm/LTO/LTO.h

@@ -350,11 +350,6 @@ class LTO {
     DenseMap<GlobalValue::GUID, StringRef> PrevailingModuleForGUID;
   } ThinLTO;
 
-  std::unique_ptr<llvm::BumpPtrAllocator> Alloc;
-
-  // Symbol saver for global resolution map.
-  std::unique_ptr<llvm::StringSaver> GlobalResolutionSymbolSaver;
-
   // The global resolution for a particular (mangled) symbol name. This is in
   // particular necessary to track whether each symbol can be internalized.
   // Because any input file may introduce a new cross-partition reference, we
@@ -412,6 +407,12 @@ class LTO {
     };
   };
 
+  // GlobalResolutionSymbolSaver allocator.
+  std::unique_ptr<llvm::BumpPtrAllocator> Alloc;
+
+  // Symbol saver for global resolution map.
+  std::unique_ptr<llvm::StringSaver> GlobalResolutionSymbolSaver;
+
   // Global mapping from mangled symbol names to resolutions.
   // Make this an unique_ptr to guard against accessing after it has been reset
   // (to reduce memory after we're done with it).