change 2 for loops to 1

kmpeng · kmpeng · commit 0fe55a532089 · 2025-07-17T15:19:31.000-07:00
diff --git a/llvm/lib/Target/DirectX/DXILFinalizeLinkage.cpp b/llvm/lib/Target/DirectX/DXILFinalizeLinkage.cpp
@@ -29,16 +29,12 @@ static bool finalizeLinkage(Module &M) {
   }
 
   // Remove unused global variables.
-  SmallVector<GlobalVariable *> ToErase;
-  for (GlobalVariable &GV : M.globals()) {
+  for (GlobalVariable &GV : make_early_inc_range(M.globals())) {
     if (GV.use_empty()) {
-      ToErase.push_back(&GV);
+      GV.eraseFromParent();
+      MadeChange = true;
     }
   }
-  for (GlobalVariable *GV : ToErase) {
-    GV->eraseFromParent();
-    MadeChange = true;
-  }
 
   SmallVector<Function *> Funcs;
 

Original file line number	Diff line number	Diff line change
`@@ -29,16 +29,12 @@ static bool finalizeLinkage(Module &M) {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`// Remove unused global variables.`
`32`		`- SmallVector<GlobalVariable *> ToErase;`
`33`		`- for (GlobalVariable &GV : M.globals()) {`
	`32`	`+ for (GlobalVariable &GV : make_early_inc_range(M.globals())) {`
`34`	`33`	`if (GV.use_empty()) {`
`35`		`- ToErase.push_back(&GV);`
	`34`	`+ GV.eraseFromParent();`
	`35`	`+ MadeChange = true;`
`36`	`36`	`}`
`37`	`37`	`}`
`38`		`- for (GlobalVariable *GV : ToErase) {`
`39`		`- GV->eraseFromParent();`
`40`		`- MadeChange = true;`
`41`		`- }`
`42`	`38`
`43`	`39`	`SmallVector<Function *> Funcs;`
`44`	`40`