Skip to content

Commit 0c07efd

Browse files
authored
[compiler-rt] Removed unnecessary 'REQUIRES: shell' from lit tests. (#157951)
As part of our work to migrate tests to use the lit internal shell by default, this removes 'REQUIRES: shell' from tests that don't actually require it. In one case the test was updated slightly to pass without requiring shell.
1 parent 10cb685 commit 0c07efd

File tree

8 files changed

+1
-20
lines changed

8 files changed

+1
-20
lines changed

compiler-rt/test/asan/TestCases/Darwin/duplicate_os_log_reports.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// UNSUPPORTED: ios
2-
// REQUIRES: shell
32
// REQUIRES: darwin_log_cmd
43
// RUN: %clangxx_asan -fsanitize-recover=address %s -o %t
54
// RUN: { %env_asan_opts=halt_on_error=0,log_to_syslog=1 %run %t > %t.process_output.txt 2>&1 & } \

compiler-rt/test/asan/TestCases/Linux/read_binary_name_regtest.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
// will be unable to resolve its $ORIGIN due to readlink() restriction and will
77
// thus fail to start, causing the test to die with SIGPIPE when attempting to
88
// talk to it.
9-
// RUN: not ls /usr/include/linux/seccomp.h || ( %clang_asan %s -o %t && ( not env ASAN_OPTIONS=symbolize=0 %run %t 2>&1 ) | FileCheck %s )
10-
// REQUIRES: shell
9+
// RUN: not ls /usr/include/linux/seccomp.h || %clang_asan %s -o %t || not env ASAN_OPTIONS=symbolize=0 %run %t 2>&1 | FileCheck %s
1110
// UNSUPPORTED: android
1211

1312
#include <errno.h>

compiler-rt/test/asan/TestCases/suppressions-library.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
// Check that without suppressions, we catch the issue.
55
// RUN: not %run %t 2>&1 | FileCheck --check-prefix=CHECK-CRASH %s
66

7-
// REQUIRES: shell
8-
97
// RUN: echo "interceptor_via_lib:"%xdynamiclib_filename > %t.supp
108
// RUN: %env_asan_opts=suppressions='"%t.supp"' %run %t 2>&1 | FileCheck --check-prefix=CHECK-IGNORE %s
119

compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// RUN: rm -rf %t-dir && mkdir -p %t-dir
22
// RUN: %clangxx_asan %s -o %t-dir/verbose-log-path_test-binary
33

4-
// The glob below requires bash.
5-
// REQUIRES: shell
6-
74
// Good log_path.
85
// RUN: rm -f %t-dir/asan.log.*
96
// RUN: %env_asan_opts=log_path=%t-dir/asan.log:log_exe_name=1 not %run %t-dir/verbose-log-path_test-binary 2> %t.out

compiler-rt/test/sanitizer_common/TestCases/external_symbolizer_path.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
// RUN: %env_tool_opts=external_symbolizer_path=%d/external_symbolizer_path.cpp.tmp.bin/llvm-symbolizer \
2020
// RUN: %run %t 2>&1 | FileCheck %s --check-prefix=NOT-FOUND
2121

22-
// REQUIRES: shell
23-
2422
// Mobile device will not have symbolizer in provided path.
2523
// UNSUPPORTED: ios, android
2624

compiler-rt/test/sanitizer_common/TestCases/suffix-log-path_test.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// RUN: mkdir -p %t.dir
33
// RUN: %clang %s -o %t.dir/suffix-log-path_test-binary
44

5-
// The glob below requires bash.
6-
// REQUIRES: shell
7-
85
// Good log_path with suffix.
96
// RUN: %env_tool_opts=log_path=%t.dir/sanitizer.log:log_exe_name=1:log_suffix=.txt %run %t.dir/suffix-log-path_test-binary 2> %t.out
107
// RUN: FileCheck %s < %t.dir/sanitizer.log.suffix-log-path_test-binary.*.txt

compiler-rt/test/ubsan/TestCases/Misc/coverage-levels.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
// Test various levels of coverage
22
//
3-
// FIXME: Port the environment variable logic below for the lit shell.
4-
// REQUIRES: shell
5-
//
63
// RUN: rm -rf %t-dir && mkdir %t-dir
74
// RUN: %clangxx -fsanitize=shift -DGOOD_SHIFT=1 -O1 -fsanitize-coverage=func,trace-pc-guard %s -o %t
85
// RUN: %env_ubsan_opts=coverage=1:verbosity=1:coverage_dir='"%t-dir"' %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1 --check-prefix=CHECK_NOWARN

compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
22
// XFAIL: android
33

4-
// The globs below do not work in the lit shell.
5-
// REQUIRES: shell
6-
74
// RUN: %clangxx -fsanitize=undefined %s -O1 -o %t
85

96
// Regular run.
@@ -38,4 +35,3 @@ int main(int argc, char *argv[]) {
3835
}
3936

4037
// CHECK-ERROR: runtime error: -4 is outside the range of representable values of type 'unsigned int'
41-

0 commit comments

Comments
 (0)