[CIR][CodeGen][NFC] Add some missing guards for unreachable

Reviewers: smeenai

Reviewed By: smeenai

Pull Request: #1022

Author: lanza

clang/include/clang/CIR/MissingFeatures.h

@@ -401,6 +401,8 @@ struct MissingFeatures {
 
   // This Itanium bit is currently being skipped in cir.
   static bool itaniumRecordLayoutBuilderFinishLayout() { return false; }
+
+  static bool mustProgress() { return false; }
 };
 
 } // namespace cir

clang/lib/CIR/CodeGen/CIRGenDecl.cpp

@@ -679,6 +679,9 @@ void CIRGenFunction::buildStaticVarDecl(const VarDecl &D,
   else if (D.hasAttr<UsedAttr>())
     llvm_unreachable("llvm.compiler.used metadata is NYI");
 
+  if (CGM.getCodeGenOpts().KeepPersistentStorageVariables)
+    llvm_unreachable("NYI");
+
   // From traditional codegen:
   // We may have to cast the constant because of the initializer
   // mismatch above.

clang/lib/CIR/CodeGen/CIRGenFunction.cpp

@@ -699,8 +699,16 @@ CIRGenFunction::generateCode(clang::GlobalDecl GD, mlir::cir::FuncOp Fn,
     if (Body && isa_and_nonnull<CoroutineBodyStmt>(Body))
       llvm::append_range(FnArgs, FD->parameters());
 
+    // Ensure that the function adheres to the forward progress guarantee, which
+    // is required by certain optimizations.
+    // In C++11 and up, the attribute will be removed if the body contains a
+    // trivial empty loop.
+    if (MissingFeatures::mustProgress())
+      llvm_unreachable("NYI");
+
     // Generate the body of the function.
     // TODO: PGO.assignRegionCounters
+    assert(!MissingFeatures::shouldInstrumentFunction());
     if (isa<CXXDestructorDecl>(FD))
       buildDestructorBody(Args);
     else if (isa<CXXConstructorDecl>(FD))
@@ -751,7 +759,7 @@ mlir::Value CIRGenFunction::createLoad(const VarDecl *VD, const char *Name) {
 }
 
 void CIRGenFunction::buildConstructorBody(FunctionArgList &Args) {
-  // TODO: EmitAsanPrologueOrEpilogue(true);
+  assert(!MissingFeatures::emitAsanPrologueOrEpilogue());
   const auto *Ctor = cast<CXXConstructorDecl>(CurGD.getDecl());
   auto CtorType = CurGD.getCtorType();
 

clang/lib/CIR/CodeGen/CIRGenModule.cpp

@@ -2434,6 +2434,8 @@ mlir::cir::FuncOp CIRGenModule::createRuntimeFunction(
   if (AssumeConvergent) {
     llvm_unreachable("NYI");
   }
+  if (Local)
+    llvm_unreachable("NYI");
 
   auto entry = GetOrCreateCIRFunction(Name, Ty, GlobalDecl(),
                                       /*ForVtable=*/false);