[HLSLResource] Don't include Metadata.h (NFC)

This is only used for a single assert, so move it out of line.
This avoids a dependency on Metadata.h from large parts of clang.

Author: nikic

llvm/include/llvm/Frontend/HLSL/HLSLResource.h

@@ -13,11 +13,11 @@
 #ifndef LLVM_FRONTEND_HLSL_HLSLRESOURCE_H
 #define LLVM_FRONTEND_HLSL_HLSLRESOURCE_H
 
-#include "llvm/IR/Metadata.h"
 #include "llvm/Support/DXILABI.h"
 
 namespace llvm {
 class GlobalVariable;
+class MDNode;
 
 namespace hlsl {
 
@@ -38,10 +38,7 @@ class FrontendResource {
   MDNode *Entry;
 
 public:
-  FrontendResource(MDNode *E) : Entry(E) {
-    assert(Entry->getNumOperands() == 6 && "Unexpected metadata shape");
-  }
-
+  FrontendResource(MDNode *E);
   FrontendResource(GlobalVariable *GV, ResourceKind RK, ElementType ElTy,
                    bool IsROV, uint32_t ResIndex, uint32_t Space);
 

llvm/lib/Frontend/HLSL/HLSLResource.cpp

@@ -51,6 +51,10 @@ uint32_t FrontendResource::getSpace() {
       ->getLimitedValue();
 }
 
+FrontendResource::FrontendResource(MDNode *E) : Entry(E) {
+  assert(Entry->getNumOperands() == 6 && "Unexpected metadata shape");
+}
+
 FrontendResource::FrontendResource(GlobalVariable *GV, ResourceKind RK,
                                    ElementType ElTy, bool IsROV,
                                    uint32_t ResIndex, uint32_t Space) {