Skip to content

Conversation

@mattycourtney
Copy link
Contributor

@mattycourtney mattycourtney commented Feb 4, 2021

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Added environment variables to control NetBox's remote authentication configuration parameters

Benefits of this PR and context:

This PR enables users of the container image to control NetBox's remote authentication configuration parameters using environment variables.

Configuring remote authentication facilitates SSO via reverse proxy servers that add a HTTP header to indicate the authenticated user's identity.

How Has This Been Tested?

  • Tested the change with the the Jenkins Builder (running locally) and confirmed that the generated README.md file was correct
  • Deployed a container with none of the REMOTE_AUTH_* environment variables set, and validated that the generated configuration.py file was as expected
  • Deployed a container with REMOTE_AUTH_* environment variables set, and validated that the values were present in the configuration.py file

Source / References:

@LinuxServer-CI
Copy link
Contributor

@mattycourtney
Copy link
Contributor Author

I'm really keen to see this get merged, as I use REMOTE_AUTH to SSO to Netbox hosted behind an identity aware proxy. Please let me know if there's any more detail I can provide within this PR that will aid your evaluation.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mattycourtney
Copy link
Contributor Author

bump

@mattycourtney mattycourtney changed the title Added remote authentication environment variables Added remote authentication environment variables Mar 22, 2021
@LinuxServer-CI
Copy link
Contributor

@alex-phillips alex-phillips merged commit f9b3f7c into linuxserver:master Mar 25, 2021
@alex-phillips
Copy link
Member

LGTM

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants