Take a better approach to hide toolbar if we're on the desktop #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default behavior in most autotools projects.
Author
|
Any chance to have this pacthes on master? |
Member
|
Hi ecanuto, thanks for the pull. We're looking into it. There's two different things here, the packaging and the toolbar. I've got admit I'm not really savvy with neither of them. I'm trying to get glebihan to review them. If you pass by #linuxmint-dev on irc.spotchat.org, come and say hello, I'd love to talk about these. |
Contributor
|
I guess the packaging commits can be removed with #42 |
Closed
Closed
ghost
mentioned this pull request
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this is a better approach.