Skip to content

Conversation

@ViktorT-11
Copy link
Contributor

This PR bumps the litd version to v0.13.5-alpha.

This PR also bumps loop to v0.28.8-beta. Notably, the actual loop reference points to a branch based on top of
the v0.28.8-beta tag, which modifies v0.28.8-beta to use lnd version v0.18.3-beta rather than v0.18.3-beta.rc1.

@Lexie2520

This comment was marked as spam.

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM 🎉

This commit updates the `loop` dependency to version `v0.28.8-beta`.
Notably, the actual `loop` reference points to a branch based on top of
the `v0.28.8-beta` tag, which modifies `v0.28.8-beta` to use `lnd`
version `v0.18.3-beta` rather than `v0.18.3-beta.rc1`.

Additionally, we upgrade `github.com/lightninglabs/loop/swapserverrpc`
to version `v1.0.10`.
As `loop/swapserverrpc` `v1.0.10` references the `reservation.proto`, we
need to modify the `build-protos.js` script to include it as on of the
fetched protos files.
@ViktorT-11 ViktorT-11 force-pushed the 2024-10-litd-v0_13_5 branch from 74affc6 to d72a2ce Compare October 25, 2024 17:49
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

Tested Loops via the litd UI and Terminal UI. Didn't run into any issues.

@ViktorT-11
Copy link
Contributor Author

Thanks a lot for the reviews @Lexie2520, @guggero & @jamaljsr 🙏!

@ViktorT-11 ViktorT-11 merged commit 4e343f4 into lightninglabs:master Oct 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants