multi: add some litd client helpers #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oops, I clicked the wrong button and added a merge commit. Can you rebase please? |
ellemouton
force-pushed
the
addJsonRegistrations
branch
from
1c93ae3 to
c7c15af
Compare
This commit adds a new litclient package which can hold anything that LiT clients may want to import. In this commit, we add and export a list of JSON call back registration functions that a client will have access to when using Lit.
In this commit, a new withAllSubServers option is added to the perms.NewManager function. If its value is true, then all LND's subserver permissions will be added to the active permissions set regardless of whether LND was actually compiled with the necessary build tags. This is useful for Lit clients who perhaps can never know which sub-servers LND was compiled with and so want to assume that it was compiled with all.
ellemouton
force-pushed
the
addJsonRegistrations
branch
from
c7c15af to
bee2d62
Compare
kaloudis
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
litclientpackage and adds and exports a list of JSON callbacks that a client connecting to lit should register.withAllSubServersparam to perms.NewManager. This is useful for a client who wants to get a list of all possible permissions available to it without knowing which sub-servers LND was compiled with. This will lead to some false positives if the client tries to call the method of a sub-server that was not compiled within LND.required for lightninglabs/lightning-node-connect#66