multi: add RevokedAt field to Session #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
storeRevokedAt
branch
from
36b4cd3 to
4386d75
Compare
This commit adds a RevokedAt field to the Session structure and sets the value of the field to the current time when RevokeSession is called.
ellemouton
force-pushed
the
storeRevokedAt
branch
from
4386d75 to
46745ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, a new
RevokedAtfield is added to theSessionstruct and it is set to the current time whenRevokeSessionis called. Note that since it is a new field, old sessions will have a zero valueRevokedAttime and so readers of a session should still use the sesssion'sStatusfield to determine if a session is revoked or not.