multi: support using a regex when specifying custom perms #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
wildCardURIs
branch
from
ce2c146 to
ebde9ea
Compare
Contributor
itsrachelfish
left a comment
itsrachelfish
left a comment
There was a problem hiding this comment.
This looks good, just found one typo.
Going to use this branch while testing my permission changes 👍
|
@ellemouton, remember to re-request review from reviewers when ready |
ellemouton
force-pushed
the
wildCardURIs
branch
from
ebde9ea to
06138ea
Compare
ellemouton
force-pushed
the
wildCardURIs
branch
from
06138ea to
2819fc6
Compare
guggero
reviewed
Nov 22, 2022
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice work! Pretty straightforward implementation, just an idea for making it even more generic.
ellemouton
force-pushed
the
wildCardURIs
branch
from
2819fc6 to
77fbaaf
Compare
ellemouton
changed the title
ellemouton
force-pushed
the
wildCardURIs
branch
from
77fbaaf to
22b891b
Compare
guggero
approved these changes
Nov 28, 2022
Member
Author
|
@itsrachelfish , this is ready for a final review :) |
itsrachelfish
approved these changes
Nov 29, 2022
Contributor
itsrachelfish
left a comment
itsrachelfish
left a comment
There was a problem hiding this comment.
tACK, regex support works, but the examples & tests could be updated to be more clear.
With this commit, a user can now specify a regex when specifying custom permissions for an LNC session. This regex will be used to select permissions for URIs that match the regex.
ellemouton
force-pushed
the
wildCardURIs
branch
from
22b891b to
15cd1bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, you can now use the wild card character when specifying custom URIs that permissions should be added for in an LNC session. This allows you to do the following:
The above will create a session that has the perms to only access the
ListChannelscall of thelnrpc.Lightningbut then also has the perms to access any URI that falls under thepoolrpc.Traderservice.`
Fixes #439