rpc_proxy+terminal: add LND and LiT to status server

Author: ellemouton

rpc_proxy.go

@@ -587,18 +587,17 @@ func (p *rpcProxy) checkSubSystemStarted(requestURI string) error {
 		return ErrWaitingToStart
 	}
 
-	// Currently, Lit and LND are not registered with the sub-server
-	// manager, so we let any request for them through.
-	if p.permsMgr.IsSubServerURI(subservers.LIT, requestURI) ||
-		p.permsMgr.IsSubServerURI(subservers.LND, requestURI) {
+	handled, system := p.subServerMgr.Handles(requestURI)
+	switch {
+	case handled:
 
-		return nil
-	}
+	case p.permsMgr.IsSubServerURI(subservers.LIT, requestURI):
+		system = subservers.LIT
 
-	// Check that the sub-server manager does have a sub-server registered
-	// that can handle the given URI.
-	handled, system := p.subServerMgr.Handles(requestURI)
-	if !handled {
+	case p.permsMgr.IsSubServerURI(subservers.LND, requestURI):
+		system = subservers.LND
+
+	default:
 		return fmt.Errorf("unknown gRPC web request: %v", requestURI)
 	}
 

terminal.go

@@ -229,6 +229,10 @@ func (g *LightningTerminal) Run() error {
 		return fmt.Errorf("could not create permissions manager")
 	}
 
+	// Register LND and LiT with the status manager.
+	g.statusMgr.RegisterSubServer(subservers.LND)
+	g.statusMgr.RegisterSubServer(subservers.LIT)
+
 	// Create the instances of our subservers now so we can hook them up to
 	// lnd once it's fully started.
 	g.subServerMgr = subservers.NewManager(g.permsMgr, g.statusMgr)
@@ -268,8 +272,9 @@ func (g *LightningTerminal) Run() error {
 	// could not start or LND could not start or be connected to.
 	startErr := g.start()
 	if startErr != nil {
-		log.Errorf("Error starting Lightning Terminal: %v", startErr)
-		return startErr
+		g.statusMgr.SetErrored(
+			subservers.LIT, "could not start Lit: %v", startErr,
+		)
 	}
 
 	// Now block until we receive an error or the main shutdown
@@ -301,7 +306,6 @@ func (g *LightningTerminal) Run() error {
 // returned.
 func (g *LightningTerminal) start() error {
 	var err error
-
 	g.accountService, err = accounts.NewService(
 		filepath.Dir(g.cfg.MacaroonPath), g.errQueue.ChanIn(),
 	)
@@ -461,10 +465,18 @@ func (g *LightningTerminal) start() error {
 	case <-readyChan:
 
 	case err := <-g.errQueue.ChanOut():
-		return err
+		g.statusMgr.SetErrored(
+			subservers.LND, "error from errQueue channel",
+		)
+
+		return fmt.Errorf("could not start LND: %v", err)
 
 	case <-lndQuit:
-		return nil
+		g.statusMgr.SetErrored(
+			subservers.LND, "lndQuit channel closed",
+		)
+
+		return fmt.Errorf("LND has stopped")
 
 	case <-interceptor.ShutdownChannel():
 		return fmt.Errorf("received the shutdown signal")
@@ -494,6 +506,10 @@ func (g *LightningTerminal) start() error {
 	// Connect to LND.
 	g.lndConn, err = connectLND(g.cfg, bufRpcListener)
 	if err != nil {
+		g.statusMgr.SetErrored(
+			subservers.LND, "could not connect to LND: %v", err,
+		)
+
 		return fmt.Errorf("could not connect to LND")
 	}
 
@@ -522,7 +538,11 @@ func (g *LightningTerminal) start() error {
 		return err
 
 	case <-lndQuit:
-		return nil
+		g.statusMgr.SetErrored(
+			subservers.LND, "lndQuit channel closed",
+		)
+
+		return fmt.Errorf("LND has stopped")
 
 	case <-interceptor.ShutdownChannel():
 		return fmt.Errorf("received the shutdown signal")
@@ -538,10 +558,16 @@ func (g *LightningTerminal) start() error {
 	// Set up all the LND clients required by LiT.
 	err = g.setUpLNDClients()
 	if err != nil {
-		log.Errorf("Could not set up LND clients: %w", err)
-		return err
+		g.statusMgr.SetErrored(
+			subservers.LND, "could not set up LND clients: %v", err,
+		)
+
+		return fmt.Errorf("could not start LND")
 	}
 
+	// We can now set the status of LND as running.
+	g.statusMgr.SetRunning(subservers.LND)
+
 	// If we're in integrated and stateless init mode, we won't create
 	// macaroon files in any of the subserver daemons.
 	createDefaultMacaroons := true
@@ -568,14 +594,21 @@ func (g *LightningTerminal) start() error {
 		return fmt.Errorf("could not start litd sub-servers: %v", err)
 	}
 
+	// We can now set the status of LiT as running.
+	g.statusMgr.SetRunning(subservers.LIT)
+
 	// Now block until we receive an error or the main shutdown signal.
 	select {
 	case err := <-g.errQueue.ChanOut():
 		return fmt.Errorf("received critical error from subsystem, "+
 			"shutting down: %v", err)
 
 	case <-lndQuit:
-		return nil
+		g.statusMgr.SetErrored(
+			subservers.LND, "lndQuit channel closed",
+		)
+
+		return fmt.Errorf("LND is not running")
 
 	case <-interceptor.ShutdownChannel():
 		log.Infof("Shutdown signal received")