terminal: add disable accounts service cfg option

Author: ViktorT-11

config.go

@@ -42,13 +42,15 @@ const (
 
 	ModeIntegrated = "integrated"
 	ModeRemote     = "remote"
+	ModeEnable     = "enable"
 	ModeDisable    = "disable"
 
-	DefaultLndMode     = ModeRemote
-	defaultFaradayMode = ModeIntegrated
-	defaultLoopMode    = ModeIntegrated
-	defaultPoolMode    = ModeIntegrated
-	defaultTapMode     = ModeIntegrated
+	DefaultLndMode      = ModeRemote
+	defaultFaradayMode  = ModeIntegrated
+	defaultLoopMode     = ModeIntegrated
+	defaultPoolMode     = ModeIntegrated
+	defaultTapMode      = ModeIntegrated
+	defaultAccountsMode = ModeEnable
 
 	defaultConfigFilename = "lit.conf"
 
@@ -199,6 +201,8 @@ type Config struct {
 	TaprootAssetsMode string         `long:"taproot-assets-mode" description:"The mode to run taproot assets in, either 'integrated' (default), 'remote' or 'disable'. 'integrated' means tapd is started alongside the UI and everything is stored in tap's main data directory, configure everything by using the --taproot-assets.* flags. 'remote' means the UI connects to an existing tapd node and acts as a proxy for gRPC calls to it. 'disable' means that LiT is started without tapd" choice:"integrated" choice:"disable"`
 	TaprootAssets     *tapcfg.Config `group:"Integrated taproot assets options (use when taproot-assets=integrated)" namespace:"taproot-assets"`
 
+	AccountsMode string `long:"accounts-mode" description:"The mode to run the accounts service in, either 'enable' (default), or 'disable'. 'enable' means that LiT is started with the integrated the accounts service enabled and running. 'disable' means that LiT is started with the accounts service disabled, and all requests to the accounts service will be rejected." choice:"enable" choice:"disable"`
+
 	RPCMiddleware *mid.Config `group:"RPC middleware options" namespace:"rpcmiddleware"`
 
 	Autopilot *autopilotserver.Config `group:"Autopilot server options" namespace:"autopilot"`
@@ -314,6 +318,7 @@ func defaultConfig() *Config {
 		Pool:                 &poolDefaultConfig,
 		TaprootAssetsMode:    defaultTapMode,
 		TaprootAssets:        &tapDefaultConfig,
+		AccountsMode:         defaultAccountsMode,
 		RPCMiddleware:        mid.DefaultConfig(),
 		FirstLNCConnDeadline: defaultFirstLNCConnTimeout,
 		Autopilot: &autopilotserver.Config{

terminal.go

@@ -236,7 +236,12 @@ func (g *LightningTerminal) Run() error {
 	// Register LND, LiT and Accounts with the status manager.
 	g.statusMgr.RegisterAndEnableSubServer(subservers.LND)
 	g.statusMgr.RegisterAndEnableSubServer(subservers.LIT)
-	g.statusMgr.RegisterAndEnableSubServer(subservers.ACCOUNTS)
+	g.statusMgr.RegisterSubServer(subservers.ACCOUNTS)
+
+	// Also enable the accounts subserver if it's not disabled.
+	if g.cfg.AccountsMode != ModeDisable {
+		g.statusMgr.SetEnabled(subservers.ACCOUNTS)
+	}
 
 	// Create the instances of our subservers now so we can hook them up to
 	// lnd once it's fully started.
@@ -850,22 +855,33 @@ func (g *LightningTerminal) startInternalSubServers(
 		return nil
 	}
 
+	stopAccountService := func() {
+		if err := g.accountService.Stop(); err != nil {
+			// We only log the error if we fail to stop the service,
+			// as it's not critical that this succeeds in order to
+			// keep litd running
+			log.Errorf("Error stopping account service: %v", err)
+		}
+	}
+
 	log.Infof("Starting LiT account service")
-	err = g.accountService.Start(
-		g.lndClient.Client, g.lndClient.Router,
-		g.lndClient.ChainParams,
-	)
-	if err != nil {
-		log.Errorf("error starting account service: %v, disabling "+
-			"account service", err)
-		g.statusMgr.SetErrored(subservers.ACCOUNTS, err.Error())
+	if g.cfg.AccountsMode != ModeDisable {
+		err = g.accountService.Start(
+			g.lndClient.Client, g.lndClient.Router,
+			g.lndClient.ChainParams,
+		)
+		if err != nil {
+			log.Errorf("error starting account service: %v, "+
+				"disabling account service", err)
+			g.statusMgr.SetErrored(subservers.ACCOUNTS, err.Error())
+			stopAccountService()
+		} else {
+			g.statusMgr.SetRunning(subservers.ACCOUNTS)
+			g.accountServiceStarted = true
+		}
 	} else {
-		g.statusMgr.SetRunning(subservers.ACCOUNTS)
+		stopAccountService()
 	}
-	// Even if we error on accountService.Start, we still want to mark the
-	// service as started so that we can properly shut it down in the
-	// shutdownSubServers call.
-	g.accountServiceStarted = true
 
 	requestLogger, err := firewall.NewRequestLogger(
 		g.cfg.Firewall.RequestLogger, g.firewallDB,