firewalldb: return empty map on empty bucket

This commit returns an empty PrivacyMapReader if the privacy bucket for
the group doesn't yet exist.

Author: bitromortac

firewalldb/privacy_mapper.go

@@ -286,7 +286,9 @@ func (p *privacyMapTx) FetchAllPairs() (*PrivacyMapPairs, error) {
 
 	sessBucket := privacyBucket.Bucket(p.groupID[:])
 	if sessBucket == nil {
-		return nil, ErrNoSuchKeyFound
+		// If the bucket has not been created yet, then there are no
+		// privacy pairs yet.
+		return NewPrivacyMapPairs(nil), nil
 	}
 
 	realToPseudoBucket := sessBucket.Bucket(realToPseudoKey)

firewalldb/privacy_mapper_test.go

@@ -79,6 +79,12 @@ func TestPrivacyMapStorage(t *testing.T) {
 	pdb3 := db.PrivacyDB([4]byte{3, 3, 3, 3})
 
 	_ = pdb3.Update(func(tx PrivacyMapTx) error {
+		// Check that calling FetchAllPairs returns an empty map if
+		// nothing exists in the DB yet.
+		m, err := tx.FetchAllPairs()
+		require.NoError(t, err)
+		require.Empty(t, m.pairs)
+
 		// Add a new pair.
 		err = tx.NewPair("real 1", "pseudo 1")
 		require.NoError(t, err)

log.go

@@ -7,6 +7,7 @@ import (
 	"github.com/lightninglabs/lightning-terminal/accounts"
 	"github.com/lightninglabs/lightning-terminal/autopilotserver"
 	"github.com/lightninglabs/lightning-terminal/firewall"
+	"github.com/lightninglabs/lightning-terminal/firewalldb"
 	mid "github.com/lightninglabs/lightning-terminal/rpcmiddleware"
 	"github.com/lightninglabs/lightning-terminal/rules"
 	"github.com/lightninglabs/lightning-terminal/session"
@@ -73,6 +74,9 @@ func SetupLoggers(root *build.RotatingLogWriter, intercept signal.Interceptor) {
 	lnd.AddSubLogger(
 		root, firewall.Subsystem, intercept, firewall.UseLogger,
 	)
+	lnd.AddSubLogger(
+		root, firewalldb.Subsystem, intercept, firewalldb.UseLogger,
+	)
 	lnd.AddSubLogger(root, rules.Subsystem, intercept, rules.UseLogger)
 	lnd.AddSubLogger(
 		root, autopilotserver.Subsystem, intercept,