itest: always close raw connections

Close connections when we are not going to use them anymore (usually a
`defer` is enough)

Author: positiveblue

itest/litd_accounts_test.go

@@ -91,6 +91,7 @@ func runAccountSystemTest(t *harnessTest, node *HarnessNode, hostPort,
 	// authentication mechanism.
 	rawConn, err := connectRPC(ctxt, hostPort, tlsCertPath)
 	require.NoError(t.t, err)
+	defer rawConn.Close()
 
 	macBytes, err := ioutil.ReadFile(macPath)
 	require.NoError(t.t, err)
@@ -192,6 +193,7 @@ func testAccountRestrictionsLNC(ctxm context.Context, t *harnessTest,
 
 	rawLNCConn, err := connectMailboxWithPairingPhrase(ctxt, connectPhrase)
 	require.NoError(t.t, err)
+	defer rawLNCConn.Close()
 
 	lightningClient := lnrpc.NewLightningClient(rawLNCConn)
 

itest/litd_firewall_test.go

@@ -170,6 +170,7 @@ func testFWRateLimitAndPrivacyMapper(net *NetworkHarness, t *harnessTest) {
 	cfg := net.Alice.Cfg
 	rawConn, err := connectRPC(ctx, cfg.LitAddr(), cfg.LitTLSCertPath)
 	require.NoError(t.t, err)
+	defer rawConn.Close()
 
 	macBytes, err := ioutil.ReadFile(cfg.LitMacPath)
 	require.NoError(t.t, err)
@@ -421,6 +422,7 @@ func testHistoryLimitRule(net *NetworkHarness, t *harnessTest) {
 	cfg := net.Alice.Cfg
 	rawConn, err := connectRPC(ctx, cfg.LitAddr(), cfg.LitTLSCertPath)
 	require.NoError(t.t, err)
+	defer rawConn.Close()
 
 	macBytes, err := ioutil.ReadFile(cfg.LitMacPath)
 	require.NoError(t.t, err)
@@ -597,6 +599,7 @@ func testChanPolicyBoundsRule(net *NetworkHarness, t *harnessTest) {
 	cfg := net.Alice.Cfg
 	rawConn, err := connectRPC(ctx, cfg.LitAddr(), cfg.LitTLSCertPath)
 	require.NoError(t.t, err)
+	defer rawConn.Close()
 
 	macBytes, err := ioutil.ReadFile(cfg.LitMacPath)
 	require.NoError(t.t, err)
@@ -845,6 +848,7 @@ func testPeerAndChannelRestrictRules(net *NetworkHarness, t *harnessTest) {
 	cfg := net.Alice.Cfg
 	rawConn, err := connectRPC(ctx, cfg.LitAddr(), cfg.LitTLSCertPath)
 	require.NoError(t.t, err)
+	defer rawConn.Close()
 
 	macBytes, err := ioutil.ReadFile(cfg.LitMacPath)
 	require.NoError(t.t, err)
@@ -1177,6 +1181,7 @@ func testLargeHttpHeader(net *NetworkHarness, t *harnessTest) {
 	cfg := net.Alice.Cfg
 	rawConn, err := connectRPC(ctx, cfg.LitAddr(), cfg.LitTLSCertPath)
 	require.NoError(t.t, err)
+	defer rawConn.Close()
 
 	macBytes, err := ioutil.ReadFile(cfg.LitMacPath)
 	require.NoError(t.t, err)

itest/litd_mode_integrated_test.go

@@ -493,6 +493,7 @@ func setUpLNCConn(ctx context.Context, t *testing.T, hostPort, tlsCertPath,
 
 	rawConn, err := connectRPC(ctx, hostPort, tlsCertPath)
 	require.NoError(t, err)
+	defer rawConn.Close()
 
 	macBytes, err := ioutil.ReadFile(macPath)
 	require.NoError(t, err)
@@ -550,6 +551,7 @@ func runGRPCAuthTest(t *testing.T, hostPort, tlsCertPath, macPath string,
 
 	rawConn, err := connectRPC(ctxt, hostPort, tlsCertPath)
 	require.NoError(t, err)
+	defer rawConn.Close()
 
 	// We have a connection without any macaroon. A call should fail.
 	_, err = makeRequest(ctxt, rawConn)
@@ -593,6 +595,7 @@ func runUIPasswordCheck(t *testing.T, hostPort, tlsCertPath, uiPassword string,
 
 	rawConn, err := connectRPC(ctxt, hostPort, tlsCertPath)
 	require.NoError(t, err)
+	defer rawConn.Close()
 
 	// Make sure that a call without any metadata results in an error.
 	_, err = makeRequest(ctxt, rawConn)
@@ -976,6 +979,7 @@ func bakeSuperMacaroon(cfg *LitNodeConfig, readOnly bool) (string, error) {
 	if err != nil {
 		return "", err
 	}
+	defer rawConn.Close()
 
 	lndAdminMacBytes, err := ioutil.ReadFile(lndAdminMac)
 	if err != nil {