Skip to content

Conversation

@ellemouton
Copy link
Member

No description provided.

@ViktorT-11
Copy link
Contributor

Rebased the PR and removed the replacement of the LiT dependency as we've now updated the wasm-client to use the latest version of LiT which has support for the status cmd!

@ViktorT-11 ViktorT-11 marked this pull request as ready for review October 23, 2023 18:53
@ViktorT-11
Copy link
Contributor

Pinging @ellemouton as I can't request a review from her, as she's the author of the PR :)! Would really appreciate if you'd be able to take a quick glance to see that the changes looks good!

@ViktorT-11
Copy link
Contributor

Reworded the commit as it now only edits example/index.html.

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

I think we can merge this without @ellemouton's review since this is just the html changes.

Copy link

@itsrachelfish itsrachelfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, confirmed that the example subserver RPC is working 👍

image

@ViktorT-11 ViktorT-11 merged commit 9db0d53 into lightninglabs:master Oct 23, 2023
@ellemouton ellemouton deleted the subservers branch October 24, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants