multi: move client conn creation func to mailbox

In this commit, the MailboxRPCConnection function is renamed and moved
out of the core package and into the mailbox package.

Author: ellemouton

cmd/wasm-client/main.go

@@ -212,7 +212,7 @@ func (w *wasmClient) ConnectServer(_ js.Value, args []js.Value) interface{} {
 	// in another goroutine here. See https://pkg.go.dev/syscall/js#FuncOf.
 	go func() {
 		var err error
-		statusChecker, lndConnect, err := core.MailboxRPCConnection(
+		statusChecker, lndConnect, err := mailbox.NewClientWebsocketConn(
 			mailboxServer, pairingPhrase, localPriv, remotePub,
 			func(key *btcec.PublicKey) error {
 				return callJsCallback(

core/lnd_conn.go renamed to mailbox/create_conn.go

@@ -1,42 +1,41 @@
-package core
+package mailbox
 
 import (
 	"context"
 	"strings"
 
 	"github.com/btcsuite/btcd/btcec/v2"
-	"github.com/lightninglabs/lightning-node-connect/mailbox"
 	"github.com/lightningnetwork/lnd/keychain"
 	"google.golang.org/grpc"
 )
 
-// MailboxRPCConnection returns a merged map of all litd's method
-// permissions.
-func MailboxRPCConnection(mailboxServer, pairingPhrase string,
+// NewClientWebsocketConn attempts to create websocket LNC client connection to
+// a server connection listening at the given mailbox server.
+func NewClientWebsocketConn(mailboxServer, pairingPhrase string,
 	localStatic keychain.SingleKeyECDH, remoteStatic *btcec.PublicKey,
 	onRemoteStatic func(key *btcec.PublicKey) error,
-	onAuthData func(data []byte) error) (func() mailbox.ClientStatus,
+	onAuthData func(data []byte) error) (func() ClientStatus,
 	func() (*grpc.ClientConn, error), error) {
 
 	words := strings.Split(pairingPhrase, " ")
-	var mnemonicWords [mailbox.NumPassphraseWords]string
+	var mnemonicWords [NumPassphraseWords]string
 	copy(mnemonicWords[:], words)
-	entropy := mailbox.PassphraseMnemonicToEntropy(mnemonicWords)
+	entropy := PassphraseMnemonicToEntropy(mnemonicWords)
 
-	connData := mailbox.NewConnData(
+	connData := NewConnData(
 		localStatic, remoteStatic, entropy[:], nil, onRemoteStatic,
 		onAuthData,
 	)
 
 	ctx := context.Background()
-	transportConn, err := mailbox.NewWebsocketsClient(
+	transportConn, err := NewWebsocketsClient(
 		ctx, mailboxServer, connData,
 	)
 	if err != nil {
 		return nil, nil, err
 	}
 
-	noiseConn := mailbox.NewNoiseGrpcConn(connData)
+	noiseConn := NewNoiseGrpcConn(connData)
 
 	dialOpts := []grpc.DialOption{
 		grpc.WithContextDialer(transportConn.Dial),

mobile/mobile.go

@@ -198,7 +198,7 @@ func ConnectServer(nameSpace string, mailboxServer string, isDevServer bool,
 			return
 		}
 
-		statusChecker, lndConnect, err := core.MailboxRPCConnection(
+		statusChecker, lndConnect, err := mailbox.NewClientWebsocketConn(
 			mailboxServer, pairingPhrase, localPriv, remotePub,
 			func(key *btcec.PublicKey) error {
 				mc.mutex.Lock()