temp: trying to fix linter and android build

Author: ellemouton

.github/workflows/main.yml

@@ -27,10 +27,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: go cache
-        uses: actions/cache@v1
+        uses: actions/cache@v3
         with:
           path: /home/runner/work/go
           key: lnc-${{ runner.os }}-go-${{ env.GO_VERSION }}-${{ github.job }}-${{ hashFiles('**/go.sum') }}
@@ -49,7 +49,7 @@ jobs:
         run: make build
 
       - name: gomobile install
-        run: go install golang.org/x/mobile/cmd/gomobile@v0.0.0-20220928052126-fa6bcb076835
+        run: go install golang.org/x/mobile/cmd/gomobile@latest
 
       - name: gomobile init
         run: gomobile init
@@ -68,13 +68,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v2
-
-      - name: Fetch all history for linter
-        run: git fetch --prune --unshallow
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
 
       - name: go cache
-        uses: actions/cache@v1
+        uses: actions/cache@v3
         with:
           path: /home/runner/work/go
           key: lnc-${{ runner.os }}-go-${{ env.GO_VERSION }}-${{ github.job }}-${{ hashFiles('**/go.sum') }}
@@ -107,10 +106,10 @@ jobs:
           - unit-race
     steps:
       - name: git checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: go cache
-        uses: actions/cache@v1
+        uses: actions/cache@v3
         with:
           path: /home/runner/work/go
           key: lnc-${{ runner.os }}-go-${{ env.GO_VERSION }}-${{ github.job }}-${{ hashFiles('**/go.sum') }}
@@ -136,10 +135,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: go cache
-        uses: actions/cache@v1
+        uses: actions/cache@v3
         with:
           path: /home/runner/work/go
           key: lnc-${{ runner.os }}-go-${{ env.GO_VERSION }}-${{ github.job }}-${{ hashFiles('**/go.sum') }}

.golangci.yml

@@ -41,3 +41,7 @@ linters:
 
     # Gosec is outdated and reports false positives.
     - gosec
+
+issues:
+  # Only show newly introduced problems.
+  new-from-rev: 4008b92d81d4d62e663025c5f79ebe44b53f283c

Dockerfile-wasm

@@ -1,5 +1,5 @@
-#Get golang 1.19.2-buster as a base image
-FROM golang:1.19.2-buster as builder
+#Get golang 1.19 as a base image
+FROM golang:1.19 as builder
 
 #Define the working directory in the container
 WORKDIR /app

Makefile

@@ -99,7 +99,7 @@ macos:
 android:
 	@$(call print, "Building Android library ($(ANDROID_BUILD)).")
 	mkdir -p $(ANDROID_BUILD_DIR)
-	GOOS=js $(GOMOBILE_BIN) bind -target=android -tags="mobile $(DEV_TAGS) $(RPC_TAGS)" -androidapi 21 $(LDFLAGS_MOBILE) -v -o $(ANDROID_BUILD) $(MOBILE_PKG)
+	cd mobile; go install golang.org/x/mobile/cmd/gobind@latest; GOOS=js $(GOMOBILE_BIN) bind -target=android -tags="mobile $(DEV_TAGS) $(RPC_TAGS)" -androidapi 21 $(LDFLAGS_MOBILE) -v -o $(ANDROID_BUILD) $(MOBILE_PKG)
 
 mobile: ios android
 

mailbox/create_conn.go

@@ -18,6 +18,7 @@ func NewClientWebsocketConn(mailboxServer, pairingPhrase string,
 	func() (*grpc.ClientConn, error), error) {
 
 	words := strings.Split(pairingPhrase, " ")
+
 	var mnemonicWords [NumPassphraseWords]string
 	copy(mnemonicWords[:], words)
 	entropy := PassphraseMnemonicToEntropy(mnemonicWords)

mobile/deps.go

@@ -0,0 +1,3 @@
+package mobile
+
+import _ "golang.org/x/mobile/bind"

mobile/go.mod

@@ -7,6 +7,7 @@ require (
 	github.com/lightninglabs/lightning-node-connect v0.2.1-alpha
 	github.com/lightninglabs/lightning-terminal v0.8.5-alpha
 	github.com/lightningnetwork/lnd v0.15.5-beta
+	golang.org/x/mobile v0.0.0-20221110043201-43a038452099
 	google.golang.org/grpc v1.51.0
 	gopkg.in/macaroon-bakery.v2 v2.3.0
 	gopkg.in/macaroon.v2 v2.1.0
@@ -91,7 +92,7 @@ require (
 	github.com/lightningnetwork/lnd/queue v1.1.0 // indirect
 	github.com/lightningnetwork/lnd/ticker v1.1.0 // indirect
 	github.com/lightningnetwork/lnd/tlv v1.0.3 // indirect
-	github.com/lightningnetwork/lnd/tor v1.1.0 // indirect
+	github.com/lightningnetwork/lnd/tor v1.0.2 // indirect
 	github.com/ltcsuite/ltcd v0.0.0-20190101042124-f37f8bf35796 // indirect
 	github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
 	github.com/mholt/archiver/v3 v3.5.0 // indirect
@@ -140,7 +141,6 @@ require (
 	go.uber.org/multierr v1.6.0 // indirect
 	go.uber.org/zap v1.17.0 // indirect
 	golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3 // indirect
-	golang.org/x/mobile v0.0.0-20221110043201-43a038452099 // indirect
 	golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4 // indirect
 	golang.org/x/net v0.0.0-20220722155237-a158d28d115b // indirect
 	golang.org/x/sync v0.0.0-20220819030929-7fc1605a5dde // indirect

mobile/go.sum

@@ -585,8 +585,8 @@ github.com/lightningnetwork/lnd/tlv v1.0.3 h1:0xBZcPuXagP6f7TY/RnLNR4igE21ov6qUd
 github.com/lightningnetwork/lnd/tlv v1.0.3/go.mod h1:dzR/aZetBri+ZY/fHbwV06fNn/3UID6htQzbHfREFdo=
 github.com/lightningnetwork/lnd/tor v1.0.0/go.mod h1:RDtaAdwfAm+ONuPYwUhNIH1RAvKPv+75lHPOegUcz64=
 github.com/lightningnetwork/lnd/tor v1.0.1/go.mod h1:RDtaAdwfAm+ONuPYwUhNIH1RAvKPv+75lHPOegUcz64=
-github.com/lightningnetwork/lnd/tor v1.1.0 h1:iXO7fSzjxTI+p88KmtpbuyuRJeNfgtpl9QeaAliILXE=
-github.com/lightningnetwork/lnd/tor v1.1.0/go.mod h1:RDtaAdwfAm+ONuPYwUhNIH1RAvKPv+75lHPOegUcz64=
+github.com/lightningnetwork/lnd/tor v1.0.2 h1:GlumRkKdzXCX0AIvIi2UXKpeY1Q4RT7Lz/CfGpKSLrU=
+github.com/lightningnetwork/lnd/tor v1.0.2/go.mod h1:RDtaAdwfAm+ONuPYwUhNIH1RAvKPv+75lHPOegUcz64=
 github.com/ltcsuite/ltcd v0.0.0-20190101042124-f37f8bf35796 h1:sjOGyegMIhvgfq5oaue6Td+hxZuf3tDC8lAPrFldqFw=
 github.com/ltcsuite/ltcd v0.0.0-20190101042124-f37f8bf35796/go.mod h1:3p7ZTf9V1sNPI5H8P3NkTFF4LuwMdPl2DodF60qAKqY=
 github.com/ltcsuite/ltcutil v0.0.0-20181217130922-17f3b04680b6/go.mod h1:8Vg/LTOO0KYa/vlHWJ6XZAevPQThGH5sufO0Hrou/lA=