Base DependencyInjection setup #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Jul 12, 2023
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Could you add a bit more to the PR description and commit messages. Doesn't have to be lengthy but including the what and why for full context. Typical guide for this is https://cbea.ms/git-commit/.
Comment on lines
+23
to
30
| private void initGuiceIntoHK2Bridge(ServiceLocator serviceLocator, Injector injector) { | ||
| GuiceBridge.getGuiceBridge().initializeGuiceBridge(serviceLocator); | ||
| GuiceIntoHK2Bridge guiceBridge = serviceLocator.getService(GuiceIntoHK2Bridge.class); | ||
| guiceBridge.bridgeGuiceInjector(injector); | ||
| } |
Contributor
There was a problem hiding this comment.
Having no idea how this works, could you give a TL; DR context in the commit message?
Contributor
Author
There was a problem hiding this comment.
i think in this particular case, it would add value to include explaination-docs in code as well, working on adding it.
jkczyz
approved these changes
Jul 12, 2023
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Thanks for adding context!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10