Skip to content

Conversation

@TheBlueMatt
Copy link
Collaborator

Built on #827 which needs to go first.

@TheBlueMatt TheBlueMatt added this to the 0.0.13 milestone Mar 8, 2021
Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve pending CI :)

This matches our naming scheme better and fits better on crates.io.
Also drop the version to 0.0.1 to match our versioning scheme
better.
We also skip having different versions for different subcrates,
since that is confusing.
@TheBlueMatt
Copy link
Collaborator Author

Fixed the match in the background-processor tests so CI should pass now.

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #835 (d65d7e7) into main (c896461) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   90.99%   90.68%   -0.32%     
==========================================
  Files          48       50       +2     
  Lines       26583    26828     +245     
==========================================
+ Hits        24190    24328     +138     
- Misses       2393     2500     +107     
Impacted Files Coverage Δ
background-processor/src/lib.rs 100.00% <100.00%> (ø)
lightning/src/ln/onchaintx.rs 86.98% <0.00%> (-7.34%) ⬇️
lightning/src/ln/channelmanager.rs 83.36% <0.00%> (-2.12%) ⬇️
lightning/src/util/macro_logger.rs 87.09% <0.00%> (-1.24%) ⬇️
lightning/src/chain/chainmonitor.rs 93.05% <0.00%> (-0.89%) ⬇️
lightning/src/ln/channel.rs 87.27% <0.00%> (-0.53%) ⬇️
lightning/src/chain/channelmonitor.rs 95.40% <0.00%> (-0.14%) ⬇️
lightning/src/util/fuzz_wrappers.rs 0.00% <0.00%> (ø)
lightning/src/ln/functional_tests.rs 97.10% <0.00%> (+0.20%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c896461...d65d7e7. Read the comment docs.

@TheBlueMatt TheBlueMatt merged commit 8a91bd9 into lightningdevkit:main Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants