Add project tracking and conventions we want to adopt #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
approved these changes
Feb 19, 2020
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
LGTM, tested the links and they work 🥇
CONTRIBUTING.md
Outdated
| Commits should cover both issues fixed and solutions' rationale. | ||
| These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind. | ||
|
|
||
| To facilitate communication with other contributors, if you are working on a GitHub Issue please assign it to yourself using GitHub's "assignee" field. |
Contributor
There was a problem hiding this comment.
nit: Issue -> issue
TheBlueMatt
reviewed
Feb 19, 2020
CONTRIBUTING.md
Outdated
| Discussion about code base improvements happens in GitHub issues and on pull | ||
| requests. | ||
|
|
||
| Major projects are tracked [here](https://github.com/rust-bitcoin/rust-lightning/projects). Major milestones are tracked [here](https://github.com/rust-bitcoin/rust-lightning/milestones?direction=asc&sort=title&state=open). |
Collaborator
There was a problem hiding this comment.
Linebreaks at around 100 chars, please.
CONTRIBUTING.md
Outdated
| Commits should cover both issues fixed and solutions' rationale. | ||
| These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind. | ||
|
|
||
| To facilitate communication with other contributors, if you are working on a GitHub Issue please assign it to yourself using GitHub's "assignee" field. |
Collaborator
There was a problem hiding this comment.
I don't actually know if non-"triage"-permissions folks can do this. Maybe just note that you should first check that no one is assigned and then comment suggesting that you're working on it, but don't hesitate to ask if the assigned party or previous commenters are still working on it if its been a while.
Collaborator
|
Ping @moneyball |
Contributor
Author
|
I think it is ready for merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.