Include counterparty node ids in PaymentForwarded #3458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
reviewed
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3458 +/- ##
==========================================
+ Coverage 89.69% 89.86% +0.16%
==========================================
Files 130 130
Lines 107422 108677 +1255
Branches 107422 108677 +1255
==========================================
+ Hits 96354 97661 +1307
+ Misses 8672 8640 -32
+ Partials 2396 2376 -20 ☔ View full report in Codecov by Sentry. |
shaavan
force-pushed
the
i3455
branch
2 times, most recently
from
3ec8edf to
69f3136
Compare
TheBlueMatt
reviewed
Dec 11, 2024
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
LGTM, modulo one tiny nit.
This commit adds counterparty node IDs to `PaymentForwarded` to address the potential ambiguity of using `ChannelIds` alone, especially in cases like v1 0conf opens where `ChannelIds` may not be unique. Including the counterparty node IDs provides better clarity and makes the information more useful.
Member
Author
|
Updated from pr3458.02 to pr3458.03 (diff): Changes:
|
Contributor
|
Wow, so fast! Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3455
This commit adds counterparty node IDs to
PaymentForwardedto address the potential ambiguity of usingChannelIdsalone, especially in cases like v1 0conf opens whereChannelIdsmay not be unique. Including the counterparty node IDs provides better clarity and makes the information more useful.