Log how many nodes/channels we have synced when we try to route #3069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common issue in LN is not having fully synced the network graph when we attempt to send a payment. This should be improved substantially with gossip v1.5, but for now we should improve our debugability by logging how many nodes we have in our graph when we attempt to find a route.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3069 +/- ##
==========================================
- Coverage 89.83% 89.79% -0.04%
==========================================
Files 116 116
Lines 96466 96467 +1
Branches 96466 96467 +1
==========================================
- Hits 86656 86622 -34
- Misses 7263 7288 +25
- Partials 2547 2557 +10 ☔ View full report in Codecov by Sentry. |
tnull
approved these changes
May 20, 2024
Contributor
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
LGTM
Trivial, so no need for a second reviewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common issue in LN is not having fully synced the network graph when we attempt to send a payment. This should be improved substantially with gossip v1.5, but for now we should improve our debugability by logging how many nodes we have in our graph when we attempt to find a route.