Ignore .tmp files when loading ChannelMonitors in persister #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Feb 24, 2022
If we are in the middle of persisting an update to a `ChannelMonitor` when we shutdown (or crash), we'll start up with a .tmp file lying around. We should ignore it, as failure to return from the update call should have prevented the `ChannelManager` from taking any irrevocable action based on the update. We're somewhat protected from any filesystem inconsistency behavior as the `ChannelManager` will refuse to load if we're outright missing `ChannelMonitor`s. Fixes lightningdevkit#1330.
TheBlueMatt
force-pushed
the
2022-02-persister-ignore-tmp
branch
from
6998b8f to
a2a90ee
Compare
jkczyz
approved these changes
Feb 25, 2022
valentinewallace
approved these changes
Feb 26, 2022
Collaborator
Author
|
Allowed fuzz failures until we fix the honggfuzz-rs issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are in the middle of persisting an update to a
ChannelMonitorwhen we shutdown (or crash), we'll start up witha .tmp file lying around. We should ignore it, as failure to
return from the update call should have prevented the
ChannelManagerfrom taking any irrevocable action based on theupdate.
We're somewhat protected from any filesystem inconsistency behavior
as the
ChannelManagerwill refuse to load if we're outrightmissing
ChannelMonitors.Fixes #1330.