Skip to content

Conversation

@jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Feb 13, 2022

chain::Listen's interface is defined in terms of non-mutable references, so there's no need to use mutable references in lightning-block-sync.

chain::Listen's interface is defined in terms of non-mutable references,
so there's no need to use mutable references in lightning-block-sync.
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #1304 (494fe6d) into main (c931380) will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
+ Coverage   90.50%   90.87%   +0.36%     
==========================================
  Files          71       71              
  Lines       39037    40584    +1547     
==========================================
+ Hits        35329    36879    +1550     
+ Misses       3708     3705       -3     
Impacted Files Coverage Δ
lightning-block-sync/src/init.rs 93.56% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 97.22% <0.00%> (+0.01%) ⬆️
lightning/src/util/config.rs 47.82% <0.00%> (+2.17%) ⬆️
lightning/src/ln/channel.rs 92.52% <0.00%> (+3.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c931380...494fe6d. Read the comment docs.

@valentinewallace valentinewallace merged commit f138d78 into lightningdevkit:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants