Bump HTTP read timeout to match reality of Bitcoin Core blocking

[TheBlueMatt]

Bitcoin Core sucks.

[TheBlueMatt]

My sample node runs on a reasonable device with the IO over a USB2 link (yea, I know), so times out sometimes even with a timeout of THIRTY MINUTES (though USB3 should be better, very long timeouts are expected, and I've seen incredibly long timeouts on spinning rust even on very fast hosts).

[TheBlueMatt]

Took Val's doc change suggestions, will land after CI, diff is:

$ git diff-tree -U1 f75b39c9 0021320e
diff --git a/lightning-block-sync/src/http.rs b/lightning-block-sync/src/http.rs
index 4f77e733..a3935edf 100644
--- a/lightning-block-sync/src/http.rs
+++ b/lightning-block-sync/src/http.rs
@@ -29,5 +29,5 @@ const TCP_STREAM_TIMEOUT: Duration = Duration::from_secs(5);
 /// timeout as it is not uncommon for Bitcoin Core to be blocked waiting on UTXO cache flushes for
-/// upwards of 10 minutes on slow-ish devices (eg RPis with SSDs over USB). Note that we always
-/// retry once when we time out, so the maximum time we allow Bitcoin Core to block for is twice
-/// this value.
+/// upwards of 10 minutes on slow devices (e.g. RPis with SSDs over USB). Note that we always retry
+/// once when we time out, so the maximum time we allow Bitcoin Core to block for is twice this
+/// value.
 const TCP_STREAM_RESPONSE_TIMEOUT: Duration = Duration::from_secs(300);
$

[codecov]

Codecov Report

Merging #1090 (0021320) into main (8f78bbd) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
- Coverage   90.75%   90.71%   -0.05%     
==========================================
  Files          65       65              
  Lines       33948    34040      +92     
==========================================
+ Hits        30811    30880      +69     
- Misses       3137     3160      +23     

Impacted Files	Coverage Δ
lightning-block-sync/src/http.rs	93.51% <ø> (ø)
lightning/src/ln/functional_tests.rs	97.47% <0.00%> (-0.07%)	⬇️
lightning/src/ln/peer_handler.rs	49.29% <0.00%> (+3.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f78bbd...0021320. Read the comment docs.