-
Notifications
You must be signed in to change notification settings - Fork 421
Update docs to specify where PeerManager::process_events is called #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
- Coverage 90.76% 90.74% -0.02%
==========================================
Files 65 65
Lines 33894 33894
==========================================
- Hits 30764 30758 -6
- Misses 3130 3136 +6
Continue to review full report at Codecov.
|
|
@TheBlueMatt I hope this should be enough to update the docs? |
TheBlueMatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention this call in lightning-net-tokio's three public methods that create connections, but this is fine either way.
valentinewallace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK mod squashing the fixup
|
Can you squash the commits into one? Then happy to land this. |
|
I squashed it into a single commit, but for some reason the check_commits stage is failing |
|
According to github, you now have four commits in the PR. See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits for instructions on how to squash and force-push. |
0f4b741 to
432507b
Compare
|
@valentinewallace I'm not sure how your changes got in when I pushed I could only see my changes in the diff. |
ac6bd64 to
8befd6c
Compare
|
@TheBlueMatt I managed to squash the commit by following the instructions that were given, but somehow i ended up with other file changes 😓 |
8befd6c to
2f0f0c9
Compare
|
Huh! I'm not entirely sure how that happened. In any case, I went ahead and took the previous version of this PR from yesterday, squashed the commit into one, and pushed it (github, by default, allows maintainers to push to your branches that are associated with a PR). |
|
Thank you for the help! :) |
Doc changes for #1075