f - remove unneeded checks

Author: jkczyz

lightning/src/routing/scoring.rs

@@ -1151,26 +1151,22 @@ impl<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>,
 	}
 
 	fn decayed_offset_msat(&self, offset_msat: u64) -> u64 {
-		let elapsed_time = self.now.duration_since(*self.last_updated).as_secs();
 		let half_life = self.decay_params.liquidity_offset_half_life.as_secs();
-
-		match elapsed_time.checked_div(half_life) {
-			None => 0,
-			Some(decays) => match elapsed_time.checked_div(half_life / 2) {
-				None => 0,
-				Some(half_decays) => {
-					// Decay the offset by the appropriate number of half lives. If half of the next
-					// half life has passed, approximate an additional three-quarter life by summing
-					// the results of taking both the *next two* half lives instead. This helps
-					// smooth out the decay.
-					let decayed_offset_msat = offset_msat.checked_shr(decays as u32).unwrap_or(0);
-					if half_decays % 2 == 0 {
-						decayed_offset_msat
-					} else {
-						(decayed_offset_msat >> 1) + (decayed_offset_msat >> 2)
-					}
-				}
-			},
+		if half_life == 0 {
+			0
+		} else {
+			// Decay the offset by the appropriate number of half lives. If half of the next half
+			// life has passed, approximate an additional three-quarter life by summing the results
+			// of taking both the *next two* half lives instead. This helps smooth out the decay.
+			let elapsed_time = self.now.duration_since(*self.last_updated).as_secs();
+			let half_decays = elapsed_time / (half_life / 2);
+			let decays = half_decays / 2;
+			let decayed_offset_msat = offset_msat.checked_shr(decays as u32).unwrap_or(0);
+			if half_decays % 2 == 0 {
+				decayed_offset_msat
+			} else {
+				(decayed_offset_msat >> 1) + (decayed_offset_msat >> 2)
+			}
 		}
 	}
 }