Skip to content

Commit b6a9735

Browse files
author
Elias Rohrer
committed
Only log_gossip for talkative types. Revert for SendErrorMessage.
1 parent c8b731f commit b6a9735

File tree

1 file changed

+28
-3
lines changed

1 file changed

+28
-3
lines changed

lightning/src/ln/peer_handler.rs

Lines changed: 28 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ use ln::channelmanager::{SimpleArcChannelManager, SimpleRefChannelManager};
2424
use util::ser::{VecWriter, Writeable, Writer};
2525
use ln::peer_channel_encryptor::{PeerChannelEncryptor,NextNoiseStep};
2626
use ln::wire;
27+
use ln::wire::Encode;
2728
use util::atomic_counter::AtomicCounter;
2829
use util::events::{MessageSendEvent, MessageSendEventsProvider};
2930
use util::logger::Logger;
@@ -757,7 +758,19 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
757758
fn enqueue_message<M: wire::Type>(&self, peer: &mut Peer, message: &M) {
758759
let mut buffer = VecWriter(Vec::with_capacity(2048));
759760
wire::write(message, &mut buffer).unwrap(); // crash if the write failed
760-
log_trace!(self.logger, "Enqueueing message {:?} to {}", message, log_pubkey!(peer.their_node_id.unwrap()));
761+
762+
match message.type_id() {
763+
msgs::Ping::TYPE |
764+
msgs::Pong::TYPE |
765+
msgs::ChannelAnnouncement::TYPE |
766+
msgs::NodeAnnouncement::TYPE |
767+
msgs::QueryShortChannelIds::TYPE |
768+
msgs::ReplyShortChannelIdsEnd::TYPE |
769+
msgs::QueryChannelRange::TYPE |
770+
msgs::ReplyChannelRange::TYPE |
771+
msgs::GossipTimestampFilter::TYPE => log_gossip!(self.logger, "Enqueueing message {:?} to {}", message, log_pubkey!(peer.their_node_id.unwrap())),
772+
_ => log_trace!(self.logger, "Enqueueing message {:?} to {}", message, log_pubkey!(peer.their_node_id.unwrap()))
773+
};
761774
self.enqueue_encoded_message(peer, &buffer.0);
762775
}
763776

@@ -953,7 +966,19 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
953966
peer: &mut Peer,
954967
message: wire::Message<<<CMH as core::ops::Deref>::Target as wire::CustomMessageReader>::CustomMessage>
955968
) -> Result<Option<wire::Message<<<CMH as core::ops::Deref>::Target as wire::CustomMessageReader>::CustomMessage>>, MessageHandlingError> {
956-
log_gossip!(self.logger, "Received message {:?} from {}", message, log_pubkey!(peer.their_node_id.unwrap()));
969+
match message {
970+
wire::Message::Ping(_) |
971+
wire::Message::Pong(_) |
972+
wire::Message::ChannelAnnouncement(_) |
973+
wire::Message::NodeAnnouncement(_) |
974+
wire::Message::QueryShortChannelIds(_) |
975+
wire::Message::ReplyShortChannelIdsEnd(_) |
976+
wire::Message::QueryChannelRange(_) |
977+
wire::Message::ReplyChannelRange(_) |
978+
wire::Message::GossipTimestampFilter(_) => log_gossip!(self.logger, "Received message {:?} from {}", message, log_pubkey!(peer.their_node_id.unwrap())),
979+
_ => log_trace!(self.logger, "Received message {:?} from {}", message, log_pubkey!(peer.their_node_id.unwrap()))
980+
};
981+
957982
peer.received_message_since_timer_tick = true;
958983

959984
// Need an Init as first message
@@ -1391,7 +1416,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
13911416
log_debug!(self.logger, "Received a HandleError event to be ignored for node {}", log_pubkey!(node_id));
13921417
},
13931418
msgs::ErrorAction::SendErrorMessage { ref msg } => {
1394-
log_gossip!(self.logger, "Handling SendErrorMessage HandleError event in peer_handler for node {} with message {}",
1419+
log_trace!(self.logger, "Handling SendErrorMessage HandleError event in peer_handler for node {} with message {}",
13951420
log_pubkey!(node_id),
13961421
msg.data);
13971422
self.enqueue_message(get_peer_for_forwarding!(node_id), msg);

0 commit comments

Comments
 (0)