Setting the constant MAX_CHANNEL_HINTS at the file level

Author: upjohnc

lightning-invoice/src/utils.rs

@@ -133,6 +133,8 @@ where
 	)
 }
 
+const MAX_CHANNEL_HINTS: usize = 3;
+
 fn _create_phantom_invoice<ES: Deref, NS: Deref, L: Deref>(
 	amt_msat: Option<u64>, payment_hash: Option<PaymentHash>, description: InvoiceDescription,
 	invoice_expiry_delta_secs: u32, phantom_route_hints: Vec<PhantomRouteHints>, entropy_source: ES,
@@ -203,9 +205,8 @@ where
 		invoice = invoice.amount_milli_satoshis(amt);
 	}
 
-	const MAX_HINTS: usize = 3;
 
-	for route_hint in select_phantom_hints(amt_msat, phantom_route_hints, logger).take(MAX_HINTS) {
+	for route_hint in select_phantom_hints(amt_msat, phantom_route_hints, logger).take(MAX_CHANNEL_HINTS) {
 		invoice = invoice.private_route(route_hint);
 	}
 
@@ -641,7 +642,7 @@ where
 				// look at the public channels instead.
 				log_trace!(logger, "Not including channels in invoice route hints on account of public channel {}",
 					log_bytes!(channel.channel_id));
-				return vec![].into_iter().take(3).map(route_hint_from_channel);
+				return vec![].into_iter().take(MAX_CHANNEL_HINTS).map(route_hint_from_channel);
 			}
 		}
 
@@ -751,7 +752,7 @@ where
 				b.inbound_capacity_msat.cmp(&a.inbound_capacity_msat)
 			}});
 
-		eligible_channels.into_iter().take(3).map(route_hint_from_channel)
+		eligible_channels.into_iter().take(MAX_CHANNEL_HINTS).map(route_hint_from_channel)
 }
 
 /// prefer_current_channel chooses a channel to use for route hints between a currently selected and candidate