Omit unnecessary clone.

Author: tnull

lightning/src/routing/router.rs

@@ -1460,23 +1460,22 @@ where L::Target: Logger {
 
 		// Step (6).
 		// Do a Fisher-Yates shuffle to create a unique permutation of the payment paths
-		let cur_payment_paths = loop {
-			let mut cur_perm = payment_paths.clone();
-			for cur_index in (1..cur_perm.len()).rev() {
+		loop {
+			for cur_index in (1..payment_paths.len()).rev() {
 				prng.process_in_place(&mut random_index_bytes);
 				let random_index = usize::from_be_bytes(random_index_bytes).wrapping_rem(cur_index+1);
-				cur_perm.swap(cur_index, random_index);
+				payment_paths.swap(cur_index, random_index);
 			}
-			let cur_perm_scids = cur_perm.iter().map(|path|
+			let cur_perm_scids = payment_paths.iter().map(|path|
 				path.hops.iter().map(|(hop,_)| hop.candidate.short_channel_id()).collect::<Vec<u64>>()
 				).collect::<Vec<Vec<u64>>>();
 			if seen_permutation_scids.insert(cur_perm_scids) {
-				break cur_perm;
+				break;
 			}
 		};
 
 		// Step (7).
-		for payment_path in cur_payment_paths {
+		for payment_path in &payment_paths {
 			cur_route.push(payment_path.clone());
 			aggregate_route_value_msat += payment_path.get_value_msat();
 			if aggregate_route_value_msat > final_value_msat {