Merge pull request #3441 from arik-so/2024-12-lint-fixes

Author: tnull

ci/check-lint.sh

@@ -35,6 +35,7 @@ RUSTFLAGS='-D warnings' cargo clippy -- \
 	-A clippy::len_without_is_empty \
 	-A clippy::len_zero \
 	-A clippy::let_and_return \
+	-A clippy::manual_div_ceil `# to be removed once we hit MSRV 1.73.0` \
 	-A clippy::manual_filter \
 	-A clippy::manual_map \
 	-A clippy::manual_memcpy \

lightning/src/ln/channelmanager.rs

@@ -711,7 +711,6 @@ impl Into<u16> for FailureCode {
 /// immediately (ie with no further calls on it made). Thus, this step happens inside a
 /// peer_state lock. We then return the set of things that need to be done outside the lock in
 /// this struct and call handle_error!() on it.
-
 struct MsgHandleErrInternal {
 	err: msgs::LightningError,
 	closes_channel: bool,

lightning/src/onion_message/messenger.rs

@@ -210,7 +210,7 @@ for OnionMessenger<ES, NS, L, NL, MR, OMH, APH, DRH, CMH> where
 ///     &offers_message_handler, &async_payments_message_handler, &dns_resolution_message_handler,
 ///     &custom_message_handler,
 /// );
-
+///
 /// # #[derive(Debug)]
 /// # struct YourCustomMessage {}
 /// impl Writeable for YourCustomMessage {

lightning/src/sync/mod.rs

@@ -46,7 +46,7 @@ mod ext_impl {
 		}
 		type ExclLock = MutexGuard<'a, T>;
 		#[inline]
-		fn unsafe_well_ordered_double_lock_self(&'a self) -> MutexGuard<T> {
+		fn unsafe_well_ordered_double_lock_self(&'a self) -> MutexGuard<'a, T> {
 			self.lock().unwrap()
 		}
 	}
@@ -57,7 +57,7 @@ mod ext_impl {
 		}
 		type ExclLock = RwLockWriteGuard<'a, T>;
 		#[inline]
-		fn unsafe_well_ordered_double_lock_self(&'a self) -> RwLockWriteGuard<T> {
+		fn unsafe_well_ordered_double_lock_self(&'a self) -> RwLockWriteGuard<'a, T> {
 			self.write().unwrap()
 		}
 	}