f try clean up TxAddInput Readable impl

Author: dunxen

lightning/src/ln/msgs.rs

@@ -24,7 +24,6 @@
 //! raw socket events into your non-internet-facing system and then send routing events back to
 //! track the network on the less-secure system.
 
-use bitcoin::consensus::deserialize;
 use bitcoin::secp256k1::PublicKey;
 use bitcoin::secp256k1::ecdsa::Signature;
 use bitcoin::{secp256k1, Witness, Transaction};
@@ -1586,12 +1585,10 @@ impl Readable for TxAddInput {
 	fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
 		let channel_id = Readable::read(r)?;
 		let serial_id = Readable::read(r)?;
-		let prevtx_len: u16 = Readable::read(r)?;
-		let mut prevtx_bytes: Vec<u8> = Vec::with_capacity(prevtx_len as usize);
-		for _ in 0..prevtx_len {
-			prevtx_bytes.push(Readable::read(r)?);
-		}
-		let prevtx = deserialize(&prevtx_bytes).map_err(|_| DecodeError::InvalidValue)?;
+		let prevtx_len = <u16 as Readable>::read(r)? as usize;
+		let mut prevtx_buf = vec![0; prevtx_len];
+		r.read_exact(&mut prevtx_buf)?;
+		let prevtx: Transaction = Readable::read(&mut prevtx_buf.as_slice())?;
 		let prevtx_out = Readable::read(r)?;
 		let sequence = Readable::read(r)?;