Add TODOs and known bugs

Author: TheBlueMatt

lightning/src/ln/channelmanager.rs

@@ -358,6 +358,7 @@ struct PeerState {
 /// For users who don't want to bother doing their own payment preimage storage, we also store that
 /// here.
 struct PendingInboundPayment {
+	//XXX: IMPLEMENT time outs, note that we MUST also fail any claimable_htlcs when we do so!
 	payment_secret: PaymentSecret,
 	expiry_height: u32,
 	value_msat: Option<u64>,
@@ -1965,6 +1966,9 @@ impl<Signer: Sign, M: Deref, T: Deref, K: Deref, F: Deref, L: Deref> ChannelMana
 									} else { true }
 								} {
 									log_trace!(self.logger, "Failing new HTLC with payment_hash {} as it didn't match our expected payment secret.", log_bytes!(payment_hash.0));
+                                    // XXX: We don't handle this identically here! There is a
+                                    // second PendingHTLCsForwardable event instead of an immediate
+                                    // claim, which is incorrect?
 									fail_htlc!(claimable_htlc);
 								} else {
 									let mut total_value = 0;

lightning/src/ln/functional_tests.rs

@@ -7497,6 +7497,7 @@ fn test_check_htlc_underpaying() {
 	commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 	expect_pending_htlcs_forwardable!(nodes[1]);
 
+	expect_pending_htlcs_forwardable!(nodes[1]); //XXX
 	// Node 3 is expecting payment of 100_000 but received 10_000,
 	// it should fail htlc like we didn't know the preimage.
 	nodes[1].node.process_pending_htlc_forwards();

lightning/src/util/events.rs

@@ -70,7 +70,7 @@ pub enum Event {
 		/// should result in an HTLC fail_backwards.
 		/// Note that, in any case, this value must be passed as-is to any fail or claim calls as
 		/// the HTLC index includes this value.
-		payment_secret: Option<PaymentSecret>,
+		payment_secret: Option<PaymentSecret>, //XXX: Make this non-Optional
 		/// The value, in thousandths of a satoshi, that this payment is for. Note that you must
 		/// compare this to the expected value before accepting the payment (as otherwise you are
 		/// providing proof-of-payment for less than the value you expected!).